Skip to content

respect @noSelf on interface containing call signature #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RealColdFry wants to merge 2 commits into
base: master
Choose a base branch
from
+57 −0
Open

respect @noSelf on interface containing call signature #1724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a624d0d
respect @noself on interface containing call signature
RealColdFry May 2, 2026
223b814
replace @noSelf call-signature snapshot tests with runtime argc probes
RealColdFry May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/transformation/utils/function-context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,19 @@ function computeDeclarationContextType(context: TransformationContext, signature
return ContextType.NonVoid;
}

// Call signature inside a class or interface respects @noSelf on the enclosing class/interface
if (ts.isCallSignatureDeclaration(signatureDeclaration)) {
const scopeDeclaration = findFirstNodeAbove(
signatureDeclaration,
(n): n is ts.ClassLikeDeclaration | ts.InterfaceDeclaration =>
ts.isClassDeclaration(n) || ts.isClassExpression(n) || ts.isInterfaceDeclaration(n)
);

if (scopeDeclaration !== undefined && getNodeAnnotations(scopeDeclaration).has(AnnotationKind.NoSelf)) {
return ContextType.Void;
}
}

// When using --noImplicitSelf and the signature is defined in a file targeted by the program apply the @noSelf rule.
const program = context.program;
const options = program.getCompilerOptions() as CompilerOptions;
Expand Down
44 changes: 44 additions & 0 deletions test/unit/functions/noSelfAnnotation.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,50 @@ test("@noSelf on static class methods with string key access", () => {
`.expectLuaToMatchSnapshot();
});

// https://github.com/TypeScriptToLua/TypeScriptToLua/issues/1661
// A Lua-side function observes the actual argc, so a missing @noSelf would
// surface as a phantom leading nil (argc 2 instead of 1).
const argcProbeHeader = `
function probe(...)
return select("#", ...)
end
`;

test("@noSelf on interface call signature: Lua probe sees correct argc", () => {
util.testModule`
/** @noSelf */
interface Probe { (a: string): number; }
declare const probe: Probe;
export const result = probe("hi");
`
.setLuaHeader(argcProbeHeader)
.expectToEqual({ result: 1 });
});

test("@noSelf parent interface, property typed by call-signature interface: Lua probe sees correct argc", () => {
util.testModule`
/** @noSelf */
interface CallSignature { (a: string): number; }
/** @noSelf */
interface Holder { fn: CallSignature; }
declare const holder: Holder;
export const result = holder.fn("hi");
`
.setLuaHeader(`${argcProbeHeader}\nholder = { fn = probe }`)
.expectToEqual({ result: 1 });
});

test("@noSelf parent interface, property typed by type-literal call signature: Lua probe sees correct argc", () => {
util.testModule`
/** @noSelf */
interface Holder { fn: { (a: string): number }; }
declare const holder: Holder;
export const result = holder.fn("hi");
`
.setLuaHeader(`${argcProbeHeader}\nholder = { fn = probe }`)
.expectToEqual({ result: 1 });
});

// additional coverage for https://github.com/TypeScriptToLua/TypeScriptToLua/issues/1292
test("explicit this parameter respected over @noSelf", () => {
util.testModule`
Expand Down
Loading