Repository navigation
feat(share): link-share settings and signed-out recipient view - #37
Conversation
e4afec2 to
44490d2
Compare
|
I've manually tested the sharing workflow, including link creation, photo selection, signed-out recipient access, city filtering, and revocation. Everything behaved as expected. The sharing acceptance tests passed across desktop, tablet, and phone (18/18). The implementation looks good within its intended mock-backed scope, and I think we can leave persistent sharing for a separate backend integration task. |
|
I've rebased this branch on top of #38 and #39 and resolved the conflicts while preserving both sharing and trip-editing functionality. I also made a few integration improvements:
All 281 acceptance tests passed (2 skipped), alongside type checks and the production build. The six mock/live boundary tests are also passing. |
kctong529
left a comment
There was a problem hiding this comment.
The implementation looks ready to merge within the agreed mock-only scope. I don't see any remaining blockers.
Merge order: Please merge #38 first, followed by #39. Afterward, retarget this PR to main and verify that its diff contains only the sharing changes before merging.
Approved, subject to that merge order and the final CI checks.
0749727 to
eee618c
Compare
Owners create a link to chosen photos of a trip, copy it and revoke it after confirming. Anyone with the link opens /s/{token} without signing in and sees only those photos, placed by city, never the exact spot. Unknown and revoked links say so. Served by the mock until the backend share endpoints exist (backend #19, #24, #25).
Keep the sharing UI available in mock mode without exposing demo sharing functionality when the frontend uses the persistent backend. - Keep the Share button visible but disabled in persistent mode, with a "coming soon" label and explanatory tooltip - Prevent public share routes from displaying mock collections when the backend is enabled, including for signed-out visitors - Reject all four sharing API operations with not_implemented instead of falling back to mock data - Prevent mock share records from being loaded from or saved to local storage in persistent mode - Document the mock-only limitation and preserve existing trip editing and sharing behavior
44490d2 to
ca385fb
Compare
Closes #28
Owners create a link to chosen photos of a trip, copy it and revoke it after confirming. Anyone with the link opens /s/{token} without signing in and sees only those photos, placed by city, never the exact spot. Unknown and revoked links say so. Served by the mock until the backend share endpoints exist (backend #19, #24, #25).