Skip to content

Added landing page, sign up/log in, page links and backend connection - #27

Merged
kctong529 merged 3 commits into
mainfrom
feat/landing-page
Oct 14, 2026
Merged

kctong529 merged 3 commits into
mainfrom
feat/landing-page

Conversation

@KALalev18

Copy link
Copy Markdown
Contributor

What I added with this PR:

  1. A landing page: When you open the site, you first see a page that explains what MapMory does. The TA asked for this at the demo gala. (I believe so)

  2. Sign up and log in pages. "Get started" takes you to sign up, "Sign in" takes you to log in, and you can switch between them. Real login isn't connected yet, so any details open the demo account. There's also a new "Sign out" button at the top.

  3. Every page has its own link now (like /dashboard, /map, /trips/123). So the browser's Back button works, refreshing keeps you on the same page, and you can copy a link to a trip. If you're logged out and open a trip link, it asks you to log in first and then takes you to that trip. Wrong links show a "Page not found" page.

  4. The app can now talk to the real backend. Showing trips and creating a trip already use @kctong529's backend when VITE_API_URL is set in .env.local. Everything else still uses the fake data until the backend has those parts.

  5. Tests for all of the above.

How to try it:

  • Run npm run dev and open the site.
  • Click Get started, then Create account. You should see the Dashboard.
  • Open a trip, press Back and refresh. You should stay where you were.
  • Click Sign out, paste a trip link, log in. You should land on that trip.

@KALalev18
KALalev18 requested a review from kctong529 October 14, 2026 15:02
@KALalev18 KALalev18 self-assigned this Oct 14, 2026
- Fetch individual trips from the backend when VITE_API_URL is configured
- Adapt API responses to the frontend TripDetail model
- Display newly created trips with an empty photo gallery
- Show the 404 page for nonexistent trips
- Preserve error handling for network and server failures
- Add regression tests for trip loading and not-found handling
- Update source-map-js from 1.2.1 to 1.2.2 via npm audit fix
@kctong529

Copy link
Copy Markdown
Contributor

I've patched the PR to address a couple of issues found during integration testing:

  • Trip detail loading: Newly created trips now load their details from the real backend instead of relying on mock data.
  • 404 handling: Nonexistent trips now display the proper "Page not found" page instead of a generic loading error.
  • Tests: Added regression tests for backend trip loading and not-found handling.
  • Dependencies: Updated source-map-js via npm audit fix.

At the time of applying this patch, the backend was also missing GET /api/trips/{trip_id}. I've just implemented that endpoint in the backend repository according to the OpenAPI contract, so both sides are now aligned.

I've verified that the complete flow works end-to-end: create a trip → receive 201 → navigate to the trip detail page → load the newly created trip from the backend.

The real photo API and authentication integration are still pending, as originally planned.

- Restructure README for easier onboarding and navigation
- Document project status and current backend integration
- Add local setup instructions using .env.example
- Clarify application routes, architecture, and API data flow
- Consolidate development commands and Playwright testing instructions
- Update Docker and deployment configuration guidance
- Summarize known limitations and link to detailed documentation

@kctong529 kctong529 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issues identified during integration testing have now been addressed, and I've verified that the trip creation and retrieval flow works end-to-end with the Go backend.

I've also added regression tests, updated the dependencies via npm audit fix, and improved the README with clearer setup instructions, .env.example, and the current backend integration status.

The remaining mock implementations and authentication integration are known limitations and can be addressed in subsequent increments.

Everything looks good for the scope of this PR.

@kctong529
kctong529 merged commit 97c8aae into main Oct 14, 2026
2 checks passed
@kctong529
kctong529 deleted the feat/landing-page branch October 14, 2026 16:49
@github-project-automation github-project-automation Bot moved this from Backlog to Done in MapMory Project Board Oct 25, 2026
@kctong529 kctong529 moved this from Backlog to Done in MapMory Project Board Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants