Repository navigation
Add points are collinear in 3d algorithm to /maths - #5983
Conversation
ghost
left a comment
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| https://math.stackexchange.com/a/1951650 | ||
| """ | ||
|
|
||
| Vector = tuple[float, float, float] |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: Vector
There was a problem hiding this comment.
This is a type-aliase.
Read More:
https://docs.python.org/3/library/typing.html#type-aliases
There was a problem hiding this comment.
@dhruvmanila Is this a problem with @algorithms-keeper logic?
| """ | ||
|
|
||
| Vector = tuple[float, float, float] | ||
| Point = tuple[float, float, float] |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: Point
There was a problem hiding this comment.
This is a type-aliase.
Read More:
https://docs.python.org/3/library/typing.html#type-aliases
There was a problem hiding this comment.
Would Vector3d and Point3d be more self-documenting names? Points are usually just x, y.
Would it be a good idea to create a Triangle3d instead of passing around three points?
There was a problem hiding this comment.
Would
Vector3dandPoint3dbe more self-documenting names? Points are usually just x, y.
Thanks for letting me know about this.
Would it be a good idea to create a
Triangle3dinstead of passing around three points?
The algorithm uses the idea of the triangle area to solve the problem, but it is actually to check for a relationship between three separate points, so I don't feel it's a good idea to use Triangle3d.
I know it's ugly to have three points and then an integer to determine the accuracy of the calculation. Should I make the accuracy variable a global one? Do you suggest any other ideas?
| return False | ||
|
|
||
|
|
||
| def are_collinear(a: Point, b: Point, c: Point, accuracy: int = 10) -> bool: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: b
Please provide descriptive name for the parameter: c
There was a problem hiding this comment.
I believe thet the type hint did the work.
| """ | ||
|
|
||
| Vector = tuple[float, float, float] | ||
| Point = tuple[float, float, float] |
There was a problem hiding this comment.
Would Vector3d and Point3d be more self-documenting names? Points are usually just x, y.
Would it be a good idea to create a Triangle3d instead of passing around three points?
Thanks to cclauss. Co-authored-by: Christian Clauss <cclauss@me.com>
ghost
left a comment
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
ghost
left a comment
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
ghost
left a comment
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
I'm not sure if /maths directory is suitable for this algorithm so if there is a better place for it please let me know in the comments.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.