You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The issue #5488 stated that there were a lot of prime functions in the repository, this PR solves that issue by unifying all the functions into one prime check function. The unified prime_check function takes O(sqrt(n)). Some special prime functions were left alone.
I would like to take a different approach to this which follows the benchmarking work done be @Leoriem-code in #5592. Instead of merely deleting code, this survival-of-the-fittest approach would put all implementations of is_prime() side-by-side in a single Python file. We could then ensure they all pass a common set of tests and run timeitbenchmarks to see which one is fastest. Whichever pure Python implementation passes all tests, is understandable, and is fastest should be exported as our current maths.is_prime() function. Putting all implementations together will allow visitors to study and understand the pros and cons of the various implementations. The timeit benchmarks would make it possible for contributors to compete to gain the throne.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fixes: #5488
The issue #5488 stated that there were a lot of prime functions in the repository, this PR solves that issue by unifying all the functions into one prime check function. The unified prime_check function takes
O(sqrt(n)). Some special prime functions were left alone.Checklist:
Fixes: #{$ISSUE_NO}.