Skip to content

First commit for add_prefix_conversion - #5453

Merged
poyea merged 5 commits into
TheAlgorithms:masterfrom
manueldilullo:add_prefix_conversion_branch
May 1, 2022
Merged

poyea merged 5 commits into
TheAlgorithms:masterfrom
manueldilullo:add_prefix_conversion_branch

Conversation

@manueldilullo

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Oct 19, 2021

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment thread conversions/add_prefix_conversion.py Resolved
Comment thread conversions/add_prefix_conversion.py Resolved
Comment thread conversions/add_prefix_conversion.py Resolved
Comment thread conversions/add_prefix_conversion.py Resolved
@ghost ghost added the tests are failing Do not merge until tests pass label Oct 19, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 19, 2021
@poyea

poyea commented Oct 20, 2021

Copy link
Copy Markdown
Member

@manueldilullo

Copy link
Copy Markdown
Contributor Author

@poyea I was inspired by this https://github.com/TheAlgorithms/Python/blob/master/conversions/prefix_conversions.py, but it works slightly differently. If I understand how it operates, prefix_conversions.py wants a known_prefix as an input to the function, so if we have a number written in his full form we can't convert it. My code works without a known_prefix, it takes the number and write it using a “notation with prefix”.
Would you suggest I open an issue and fix this directly in prefix_conversions.py instead of creating a new file?

@poyea

poyea commented Oct 21, 2021

Copy link
Copy Markdown
Member

@poyea I was inspired by this https://github.com/TheAlgorithms/Python/blob/master/conversions/prefix_conversions.py, but it works slightly differently. If I understand how it operates, prefix_conversions.py wants a known_prefix as an input to the function, so if we have a number written in his full form we can't convert it. My code works without a known_prefix, it takes the number and write it using a “notation with prefix”. Would you suggest I open an issue and fix this directly in prefix_conversions.py instead of creating a new file?

So it is to add a prefix to a number

@manueldilullo

Copy link
Copy Markdown
Contributor Author

@poyea I was inspired by this https://github.com/TheAlgorithms/Python/blob/master/conversions/prefix_conversions.py, but it works slightly differently. If I understand how it operates, prefix_conversions.py wants a known_prefix as an input to the function, so if we have a number written in his full form we can't convert it. My code works without a known_prefix, it takes the number and write it using a “notation with prefix”. Would you suggest I open an issue and fix this directly in prefix_conversions.py instead of creating a new file?

So it is to add a prefix to a number

Yes, it is

@stale

stale Bot commented Apr 30, 2022

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale Used to mark an issue or pull request stale. label Apr 30, 2022

@poyea poyea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@stale stale Bot removed the stale Used to mark an issue or pull request stale. label May 1, 2022
@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting reviews This PR is ready to be reviewed labels May 1, 2022
@poyea
poyea merged commit a7e4b23 into TheAlgorithms:master May 1, 2022
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants