Skip to content

Fix quicksort doc - #4878

Merged
poyea merged 8 commits into
TheAlgorithms:masterfrom
varopxndx:fix-quicksort
Apr 28, 2022
Merged

poyea merged 8 commits into
TheAlgorithms:masterfrom
varopxndx:fix-quicksort

Conversation

@varopxndx

Copy link
Copy Markdown
Contributor

Describe your change:

I fixed the quicksort documentation following the markdown best practices.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed documentation This PR modified documentation files labels Oct 1, 2021
@chakeson

Copy link
Copy Markdown
Contributor

This is the same as #4875 fyi

@varopxndx

Copy link
Copy Markdown
Contributor Author

Hi @chakeson
I just added another documentation to avoid problems with another partner.
I hope this works.
Thank you!

@chakeson

Copy link
Copy Markdown
Contributor

The binary traversal document is literally taken from https://github.com/azl397985856/leetcode/blob/master/thinkings/binary-tree-traversal.en.md while its in the creative common it should probably be mentioned.

@varopxndx

varopxndx commented Oct 11, 2021 •

Copy link
Copy Markdown
Contributor Author

The binary traversal document is literally taken from https://github.com/azl397985856/leetcode/blob/master/thinkings/binary-tree-traversal.en.md while its in the creative common it should probably be mentioned.

Yes, it's well explained there, I used it to review docs from there.
I just added the link to the reference.
Sorry for omitted it.
I hope this works.
Thank you!

@varopxndx

Copy link
Copy Markdown
Contributor Author

Hi @chakeson
Will my contribution be accepted?

@chakeson

chakeson commented Oct 15, 2021 •

Copy link
Copy Markdown
Contributor

I'm not a maintainer, I just try reviewed to help. They probably wont prioritise something with a spam looking pl.

@ghost ghost added the tests are failing Do not merge until tests pass label Oct 20, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 25, 2021
@poyea

poyea commented Oct 27, 2021

Copy link
Copy Markdown
Member

The binary traversal document is literally taken from https://github.com/azl397985856/leetcode/blob/master/thinkings/binary-tree-traversal.en.md while its in the creative common it should probably be mentioned.

I don't suggest copy-paste from other repos.

Comment thread sorts/normal_distribution_quick_sort.md Resolved
@stale

stale Bot commented Apr 28, 2022

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale Used to mark an issue or pull request stale. label Apr 28, 2022
@stale stale Bot removed the stale Used to mark an issue or pull request stale. label Apr 28, 2022
@ghost ghost added tests are failing Do not merge until tests pass and removed awaiting reviews This PR is ready to be reviewed labels Apr 28, 2022
@poyea
poyea merged commit 10d0e4e into TheAlgorithms:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This PR modified documentation files tests are failing Do not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants