Skip to content

[version_bump] Syncano version bump to 5.4.6#60

Merged
23doors merged 4 commits into
masterfrom
syncano_546
Nov 17, 2016
Merged

[version_bump] Syncano version bump to 5.4.6#60
23doors merged 4 commits into
masterfrom
syncano_546

Conversation

@23doors

@23doors 23doors commented Nov 17, 2016

Copy link
Copy Markdown
Member

No description provided.

@23doors

23doors commented Nov 17, 2016

Copy link
Copy Markdown
Member Author

Waiting for release of python lib. We can rebuild main script image on Monday so it gets pushed on Tuesday.

@kotchaosu kotchaosu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

@23doors

23doors commented Nov 17, 2016

Copy link
Copy Markdown
Member Author

@zhebr Found the reason why it fails. And it was not due to this PR.
In python 2.7 we use this line fails: from Tkinter import _splitdict
and it is used in newer version of future==0.16.0 here:
https://github.com/PythonCharmers/python-future/blob/master/src/tkinter/__init__.py#L7

For now fixed it by adding explicit future==0.15.2 to reqs, but possibly better solution would be to update python2.7 (don't have this issue in 2.7.12, image uses 2.7.6)

@23doors 23doors merged commit f8089de into master Nov 17, 2016
@23doors 23doors deleted the syncano_546 branch November 17, 2016 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants