Skip to content

Fix vars and input that references app context#104

Merged
m4dcoder merged 1 commit into
masterfrom
fix-app-ctx
Nov 13, 2018
Merged

Fix vars and input that references app context#104
m4dcoder merged 1 commit into
masterfrom
fix-app-ctx

Conversation

@m4dcoder

Copy link
Copy Markdown
Collaborator

Fix the construction sequence of the workflow initial context. Assign the app context as the initial context before the workflow input and vars are rendered. This allows expressions in vars and input to reference variables set in the app context.

Fix the construction sequence of the workflow initial context. Assign the app context as the initial context before the workflow input and vars are rendered. This allows expressions in vars and input to reference variables set in the app context.
@m4dcoder m4dcoder requested a review from blag November 10, 2018 22:46
@codecov-io

codecov-io commented Nov 10, 2018

Copy link
Copy Markdown

Codecov Report

Merging #104 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   94.24%   94.24%   +<.01%     
==========================================
  Files          38       38              
  Lines        2379     2381       +2     
  Branches      470      470              
==========================================
+ Hits         2242     2244       +2     
  Misses         79       79              
  Partials       58       58
Impacted Files Coverage Δ
orquesta/specs/native/v1/models.py 97.63% <100%> (ø) ⬆️
orquesta/conducting.py 91.98% <100%> (+0.03%) ⬆️
orquesta/specs/mistral/v2/workflows.py 83.01% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f24c2c7...b76a252. Read the comment docs.

@blag blag left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m4dcoder m4dcoder merged commit 3028c15 into master Nov 13, 2018
@m4dcoder m4dcoder deleted the fix-app-ctx branch November 14, 2018 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants