Fix eventlog clear false-positive filter scope#6038
Open
srkyn wants to merge 1 commit into
Open
Conversation
Contributor
|
Welcome 👋 It looks like this is your first pull request on the Sigma rules repository! Please make sure to read the SigmaHQ conventions to make sure your contribution is adhering to best practices and has all the necessary elements in place for a successful approval. Thanks again, and welcome to the Sigma community! 😃 |
e15c828 to
549110a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates one existing Windows process creation rule:
rules/windows/process_creation/proc_creation_win_susp_eventlog_clear.ymlThe current condition is parsed so the
filter_main_msiexecfalse-positive filter only applies to the WMI branch:Because
andbinds tighter thanor, the filter does not apply to the wevtutil or PowerShell branches. This PR groups the three detection branches first, then applies the filter to the full expression:It also fixes a nearby comment typo:
usettoused.Validation
Result:
Scope
This PR intentionally touches one existing rule only. No new rules are added.