From f27f91966f9c5ad2735877ab5b655b24490a963c Mon Sep 17 00:00:00 2001 From: ShaharNaveh <50263213+ShaharNaveh@users.noreply.github.com> Date: Wed, 29 Apr 2026 12:56:02 +0300 Subject: [PATCH 1/5] Cargo check features on all os --- .github/workflows/ci.yaml | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index ac1060859ad..b5937905fe0 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -79,9 +79,6 @@ jobs: - name: run rust tests run: cargo test --workspace ${{ env.WORKSPACE_EXCLUDES }} --verbose --features threading ${{ env.CARGO_ARGS }} - - name: check compilation without threading - run: cargo check ${{ env.CARGO_ARGS }} - - run: cargo doc --locked if: runner.os == 'Linux' @@ -151,6 +148,8 @@ jobs: target: aarch64-apple-ios - os: macos-latest target: x86_64-apple-darwin + - os: windows-latest + target: x86_64-pc-windows-msvc fail-fast: false steps: - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 @@ -204,7 +203,14 @@ jobs: # args: --ignore-rust-version - name: Check compilation - run: cargo check --target "${{ matrix.target }}" ${{ env.CARGO_ARGS_NO_SSL }} + run: | + echo "::group::no ssl" + cargo check --target "${{ matrix.target }}" ${{ env.CARGO_ARGS_NO_SSL }} + echo "::endgroup::" + + echo "::group::no threading" + cargo check --target "${{ matrix.target }}" ${{ env.CARGO_ARGS }} + echo "::endgroup::" env: CC_aarch64_linux_android: ${{ steps.setup-ndk.outputs.ndk-path }}/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android24-clang AR_aarch64_linux_android: ${{ steps.setup-ndk.outputs.ndk-path }}/toolchains/llvm/prebuilt/linux-x86_64/bin/llvm-ar From b824f0947fb520cd27d51516a2ee00cca3b75c9a Mon Sep 17 00:00:00 2001 From: ShaharNaveh <50263213+ShaharNaveh@users.noreply.github.com> Date: Wed, 29 Apr 2026 14:31:24 +0300 Subject: [PATCH 2/5] Adjust cargo conf --- .github/workflows/ci.yaml | 30 ++++++++++++++++++------------ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index b5937905fe0..9f40681a852 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -194,6 +194,20 @@ jobs: ndk-version: r27 add-to-path: true + - name: Append env conf to cargo + if: ${{ matrix.target == 'aarch64-linux-android' }} + env: + NDK_PATH: ${{ steps.setup-ndk.outputs.ndk-path }} + run: | + { + echo "[env]" + echo "CC_aarch64_linux_android = \"${{ env.NDK_PATH }}/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android24-clang\"" + + echo "AR_aarch64_linux_android = \"${{ env.NDK_PATH }}/toolchains/llvm/prebuilt/linux-x86_64/bin/llvm-ar\"" + + echo "CARGO_TARGET_AARCH64_LINUX_ANDROID_LINKER = \"${{ env.NDK_PATH }}/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android24-clang\"" + } >> .cargo/config.toml + # - name: Prepare repository for redox compilation # run: bash scripts/redox/uncomment-cargo.sh # - name: Check compilation for Redox @@ -202,19 +216,11 @@ jobs: # command: check # args: --ignore-rust-version - - name: Check compilation - run: | - echo "::group::no ssl" - cargo check --target "${{ matrix.target }}" ${{ env.CARGO_ARGS_NO_SSL }} - echo "::endgroup::" + - name: Check compilation without ssl + run: cargo check --target "${{ matrix.target }}" ${{ env.CARGO_ARGS_NO_SSL }} - echo "::group::no threading" - cargo check --target "${{ matrix.target }}" ${{ env.CARGO_ARGS }} - echo "::endgroup::" - env: - CC_aarch64_linux_android: ${{ steps.setup-ndk.outputs.ndk-path }}/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android24-clang - AR_aarch64_linux_android: ${{ steps.setup-ndk.outputs.ndk-path }}/toolchains/llvm/prebuilt/linux-x86_64/bin/llvm-ar - CARGO_TARGET_AARCH64_LINUX_ANDROID_LINKER: ${{ steps.setup-ndk.outputs.ndk-path }}/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android24-clang + - name: Check compilation with + run: cargo check --target "${{ matrix.target }}" ${{ env.CARGO_ARGS }} snippets_cpython: if: ${{ !contains(github.event.pull_request.labels.*.name, 'skip:ci') }} From b4ffb87f56c2d681dc1f132227453e9cf0bba2f6 Mon Sep 17 00:00:00 2001 From: ShaharNaveh <50263213+ShaharNaveh@users.noreply.github.com> Date: Wed, 29 Apr 2026 14:34:40 +0300 Subject: [PATCH 3/5] Skip unsupported ssl platforms --- .github/workflows/ci.yaml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 9f40681a852..50c68e1c774 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -136,10 +136,12 @@ jobs: target: i686-unknown-linux-musl dependencies: musl-tools: true + skip_ssl: true - os: ubuntu-latest target: wasm32-wasip2 - os: ubuntu-latest target: x86_64-unknown-freebsd + skip_ssl: true - os: ubuntu-latest target: aarch64-unknown-linux-gnu dependencies: @@ -216,10 +218,11 @@ jobs: # command: check # args: --ignore-rust-version - - name: Check compilation without ssl - run: cargo check --target "${{ matrix.target }}" ${{ env.CARGO_ARGS_NO_SSL }} + - name: Check compilation with threading + run: cargo check --target "${{ matrix.target }}" ${{ env.CARGO_ARGS_NO_SSL }} --features threading - - name: Check compilation with + - name: Check compilation with ssl + if: ${{ !matrix.skip_ssl }} run: cargo check --target "${{ matrix.target }}" ${{ env.CARGO_ARGS }} snippets_cpython: From 5c32c580b09a295a106eaa917a6af8820011f603 Mon Sep 17 00:00:00 2001 From: ShaharNaveh <50263213+ShaharNaveh@users.noreply.github.com> Date: Wed, 29 Apr 2026 15:10:41 +0300 Subject: [PATCH 4/5] zizmor --- .github/workflows/ci.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 50c68e1c774..304e16fad7c 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -203,11 +203,11 @@ jobs: run: | { echo "[env]" - echo "CC_aarch64_linux_android = \"${{ env.NDK_PATH }}/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android24-clang\"" + echo "CC_aarch64_linux_android = \"${NDK_PATH}/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android24-clang\"" - echo "AR_aarch64_linux_android = \"${{ env.NDK_PATH }}/toolchains/llvm/prebuilt/linux-x86_64/bin/llvm-ar\"" + echo "AR_aarch64_linux_android = \"${NDK_PATH}/toolchains/llvm/prebuilt/linux-x86_64/bin/llvm-ar\"" - echo "CARGO_TARGET_AARCH64_LINUX_ANDROID_LINKER = \"${{ env.NDK_PATH }}/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android24-clang\"" + echo "CARGO_TARGET_AARCH64_LINUX_ANDROID_LINKER = \"${NDK_PATH}/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android24-clang\"" } >> .cargo/config.toml # - name: Prepare repository for redox compilation From 7f870776cb7ecb05dc451c517d41db52d05c9ce6 Mon Sep 17 00:00:00 2001 From: ShaharNaveh <50263213+ShaharNaveh@users.noreply.github.com> Date: Thu, 30 Apr 2026 17:48:51 +0300 Subject: [PATCH 5/5] Remove duplicated check --- .github/workflows/ci.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 031566aa945..5bdb17911b8 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -150,8 +150,6 @@ jobs: target: aarch64-apple-ios - os: macos-latest target: x86_64-apple-darwin - - os: windows-latest - target: x86_64-pc-windows-msvc fail-fast: false steps: - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2