Fix logging to wandb in attack args for attackresults#647
Merged
jxmorris12 merged 2 commits intoMay 31, 2022
Conversation
As per the documentation , we do not have not specify project name to allow wandb create a project name automatically. Not specifying project name in AttackArgs led to AssertionError. Removed Assert line as it not required, and replaced method to get project name. Fixes QData#646
Logging Attack Results Summary to wandb is currently failing with TypeError - Data row contained incompatible types. The TypeError is because we were trying to log both Number and String entries to the same column to wandb which is not allowed. Fix involves converting string entries to float(Number) to maintain same datatype throughout the column in the table. Fixes QData#645
jxmorris12
approved these changes
May 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR fixes 2 issues seen when logging attack results to wandb
Summary
Logging Attack Results Summary to wandb is currently failing with TypeError - Data row contained incompatible types. Fix involves converting string entries to float(Number) to maintain same datatype throughout the column in the table.
As per the documentation , we do not have not specify project name to allow wandb create a project name automatically. Removed Assertion
Additions
Changes
Deletions
**Issues Addressed
Data row contained incompatible types:#645Checklist
.rstfile inTextAttack/docs/apidoc.'