feat(world): add find_nearest_biome for /locate biome#2530
Draft
ezraclintoc wants to merge 1 commit into
Draft
Conversation
Ports vanilla's BiomeSource biome search as a ring-by-ring spiral (nearest-ring-first) with a vertical scan for 3D/cave biomes. Command wiring and the noise-sampler accessor follow separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports vanilla's BiomeSource biome search as a ring-by-ring spiral (nearest-ring-first) with a vertical scan for 3D/cave biomes. Command wiring and the noise-sampler accessor follow separately.
Description
Implements
/locate biome <biome>, closing #2230 (biome subcommand only).Minecraft biomes are 3D (since 1.18), so this locates the nearest block whose sampled biome matches the requested one, scanning both horizontally and vertically. Only checks every 32 blocks horizontally and every 64 blocks vertically.
Testing
find_nearest_biome: fixed seed +Dimension::OVERWORLD, asserts aknown biome resolves to the expected coordinates.
/locate biome minecraft:desertand a cave biome (e.g.minecraft:lush_caves) in a fresh world; verified returned coords land in thetarget biome via
/tp+ F3.Please follow our Coding Guidelines