Skip to content

Simplified customer preferences#21234

Merged
matks merged 4 commits into
PrestaShop:developfrom
JevgenijVisockij:feature/simplify-customer-preferences
Dec 1, 2020
Merged

Simplified customer preferences#21234
matks merged 4 commits into
PrestaShop:developfrom
JevgenijVisockij:feature/simplify-customer-preferences

Conversation

@JevgenijVisockij

@JevgenijVisockij JevgenijVisockij commented Oct 1, 2020

Copy link
Copy Markdown
Contributor
Questions Answers
Branch? develop
Description? Simplify customer preferences form
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Part of #16482
How to test? Simplifying Shop Parameters -> Customer settings form. Everything must look the and work the same with following exceptions: 1. blue help box replaced with help text under input. 2. Password reset delay is now required(it was always required but now is shown as such 3. Error message for password reset delay appears next to the input instead of at the top of the page.

This change is Reviewable

@JevgenijVisockij JevgenijVisockij requested a review from a team as a code owner October 1, 2020 07:17
@prestonBot prestonBot added develop Branch Bug Type: Bug Improvement Type: Improvement labels Oct 1, 2020
NeOMakinG
NeOMakinG previously approved these changes Oct 1, 2020

@NeOMakinG NeOMakinG left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Progi1984 Progi1984 added migration symfony migration project and removed Bug Type: Bug labels Oct 2, 2020
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Oct 2, 2020
@Progi1984 Progi1984 linked an issue Oct 2, 2020 that may be closed by this pull request
@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label Oct 14, 2020
atomiix
atomiix previously approved these changes Oct 14, 2020
matks
matks previously approved these changes Oct 14, 2020
@matks matks added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for wording Status: action required, waiting for wording labels Oct 14, 2020
@khouloudbelguith khouloudbelguith self-assigned this Oct 15, 2020
@khouloudbelguith

Copy link
Copy Markdown
Contributor

Hi @JevgenijVisockij,

I found only one issue:
In all fields, you have a required option
image
Before, it was ok
image

Thanks to check and feedback.

@khouloudbelguith khouloudbelguith added the Waiting for author Status: action required, waiting for author feedback label Oct 16, 2020
@JevgenijVisockij JevgenijVisockij changed the title Simplified customer preferences [WIP] Simplified customer preferences Oct 28, 2020
@JevgenijVisockij

Copy link
Copy Markdown
Contributor Author

Blocked #21245 as that PR would remove uneeded red * from Yes/No types.

@JevgenijVisockij JevgenijVisockij dismissed stale reviews from matks and atomiix via 514132c November 6, 2020 16:21
@JevgenijVisockij JevgenijVisockij force-pushed the feature/simplify-customer-preferences branch from ce8bce2 to 514132c Compare November 6, 2020 16:21
@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label Nov 6, 2020
@JevgenijVisockij JevgenijVisockij changed the title [WIP] Simplified customer preferences Simplified customer preferences Nov 11, 2020
@prestonBot

prestonBot commented Nov 11, 2020

Copy link
Copy Markdown
Collaborator

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

(Note: this is an automated message, but answering it will reach a real human)

@JevgenijVisockij

Copy link
Copy Markdown
Contributor Author

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

* `Admin.Notifications.Error`
  
  * [ ]  [`The field is invalid.`](https://github.com/PrestaShop/PrestaShop/pull/21234/files#diff-cc92abd6661aff278f401928bb4395b8R81)

(Note: this is an automated message, but answering it will reach a real human)

Previous message was "The %s field is invalid" with %s being "Password reset delay" I think that message no longer makes sense since now error message is shown next to the field. Should I change message back to how it was or maybe anybody has ideas for a better error message here.

Input is considerd invalid when it's not numeric or is lower then 0.

@Julievrz

Julievrz commented Nov 18, 2020

Copy link
Copy Markdown
Contributor

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

* `Admin.Notifications.Error`
  
  * [ ]  [`The field is invalid.`](https://github.com/PrestaShop/PrestaShop/pull/21234/files#diff-cc92abd6661aff278f401928bb4395b8R81)

(Note: this is an automated message, but answering it will reach a real human)

Previous message was "The %s field is invalid" with %s being "Password reset delay" I think that message no longer makes sense since now error message is shown next to the field. Should I change message back to how it was or maybe anybody has ideas for a better error message here.

Input is considerd invalid when it's not numeric or is lower then 0.

Hi @JevgenijVisockij, sorry for the late answer!
If I understand well, it is the same error than in this PR (#21243). If yes, why not using the same wording? "The field is invalid. Please enter a positive integer number." in Admin.Notifications.Error

Also, I agree that if the error message is just next to the field, it may not be necessary to specify the name of the field again. Could you show me with a screenshot how it would appear, please?

@JevgenijVisockij

JevgenijVisockij commented Nov 18, 2020

Copy link
Copy Markdown
Contributor Author

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

* `Admin.Notifications.Error`
  
  * [ ]  [`The field is invalid.`](https://github.com/PrestaShop/PrestaShop/pull/21234/files#diff-cc92abd6661aff278f401928bb4395b8R81)

(Note: this is an automated message, but answering it will reach a real human)

Previous message was "The %s field is invalid" with %s being "Password reset delay" I think that message no longer makes sense since now error message is shown next to the field. Should I change message back to how it was or maybe anybody has ideas for a better error message here.
Input is considerd invalid when it's not numeric or is lower then 0.

Hi @JevgenijVisockij, sorry for the late answer!
If I understand well, it is the same error than in this PR (#21243). If yes, why not using the same wording? "The field is invalid. Please enter a positive integer number." in Admin.Notifications.Error

Also, I agree that if the error message is just next to the field, it may not be necessary to specify the name of the field again. Could you show me with a screenshot how it would appear, please?

Hey

I think using same wording makes sense.

And here is the screenshot
image

@Julievrz Julievrz added Wording ✔️ Status: check done, wording approved and removed Waiting for wording Status: action required, waiting for wording labels Nov 18, 2020
@atomiix atomiix removed the Waiting for author Status: action required, waiting for author feedback label Nov 24, 2020
@khouloudbelguith

Copy link
Copy Markdown
Contributor

Hi @JevgenijVisockij,

It is ok ✔️

THanks!

@khouloudbelguith khouloudbelguith added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Dec 1, 2020
@matks matks merged commit 1e2e5aa into PrestaShop:develop Dec 1, 2020
@prestashop-issue-bot prestashop-issue-bot Bot added the Fixed Resolution: issue closed because fixed label Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

develop Branch Fixed Resolution: issue closed because fixed Improvement Type: Improvement migration symfony migration project QA ✔️ Status: check done, code approved Wording ✔️ Status: check done, wording approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EPIC] Symfony Forms simplification using PrestaShop Form Theme

8 participants