Skip to content

Improve admin logs #21075

Merged
Progi1984 merged 77 commits into
PrestaShop:developfrom
PululuK:patch-7
Dec 2, 2020
Merged

Improve admin logs #21075
Progi1984 merged 77 commits into
PrestaShop:developfrom
PululuK:patch-7

Conversation

@PululuK

@PululuK PululuK commented Sep 19, 2020 •
edited
Loading

Copy link
Copy Markdown
Member
Questions Answers
Branch? develop
Description? Logs should be more verbose ! The indicators present in the logs are not complete enough to allow us to understand the origin of certain issues, mainly when we are in a multi-shop and multi-lang context. It will be interesting for example to know in which language and shop the action was made on the object.
Type? improvement
Category? CO
BC breaks? yes
Deprecations? no
Fixed ticket? Fixes #18340, #22078 and part of #16482
How to test? See 👇🏾

New features

  • Add log context datas : Shop context (all shop, group or shop) and Language
    Capture du 2020-09-20 00-27-08 (1)

  • Logs mail alert : Use ChoiceType instaed of TexType
    Capture du 2020-11-15 23-26-13 (1)

  • Add a possibility to change e-mail for notifications. Logs are meant to be for someone technical, I guess it would be some agency/webmaster email, not main email address of store. See Improve admin logs  #21075 (comment) by @kpodemski
    image

Improvements

Bugs fix

  • Search by imployee lastname/firstname
  • Fix default severity type for log mail alert during install and upgrade process (see f6125d1 and 4d6db35 )

BC Break

Backwards compatibility break introduced due to extension of TranslationAwareType instead of using TranslatorAwareTrait. This means if any module extends LogsByEmailType file they will get an exception. See #21235 by @JevgenijVisockij

This change is Reviewable

@PululuK PululuK requested a review from a team as a code owner September 19, 2020 22:47
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Sep 19, 2020
@prestonBot

prestonBot commented Sep 19, 2020 •
edited by Julievrz
Loading

Copy link
Copy Markdown
Collaborator

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label Sep 19, 2020
@PululuK PululuK mentioned this pull request Sep 19, 2020
Closed
@PululuK PululuK added Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Nov 26, 2020
PululuK and others added 2 commits November 26, 2020 11:32
@PululuK @PierreRambaud
Update src/Core/Grid/Data/Factory/LogDataFactory.php
54cf03a 
Co-authored-by: GoT <PierreRambaud@users.noreply.github.com>
@PululuK
add const DEFAULT_EMPTY_DATA
7c18ce2
@PululuK PululuK removed the Waiting for author Status: action required, waiting for author feedback label Nov 26, 2020
@Julievrz Julievrz added Wording ✔️ Status: check done, wording approved and removed Waiting for wording Status: action required, waiting for wording labels Nov 27, 2020
@PululuK PululuK added this to the 1.7.8.0 milestone Nov 27, 2020
@kpodemski kpodemski added the Waiting for QA Status: action required, waiting for test feedback label Nov 27, 2020
@SD1982 SD1982 self-assigned this Dec 1, 2020
@SD1982

SD1982 commented Dec 2, 2020

Copy link
Copy Markdown
Contributor

Hi @PululuK Everything look good to me except the "severity" filter which has the same behavior as in this issue #18480
https://drive.google.com/file/d/1fvaB2NocwSRzLChkjLtZE9lJY2ElBl9t/view?usp=sharing

@SD1982 SD1982 added the Waiting for author Status: action required, waiting for author feedback label Dec 2, 2020
@PululuK

PululuK commented Dec 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Hi @PululuK Everything look good to me except the "severity" filter which has the same behavior as in this issue #18480
https://drive.google.com/file/d/1fvaB2NocwSRzLChkjLtZE9lJY2ElBl9t/view?usp=sharing

Thanks @SD1982
I can open another PR to fix this. Its ok for you ?
@PierreRambaud WDYF ?

@Progi1984 is working on a similar issue here #21420

@SD1982

SD1982 commented Dec 2, 2020

Copy link
Copy Markdown
Contributor

As we have seen together I validate this PR and the bug detected on the "severity" filter will be corrected by another PR or maybe by #21420
Thanks again @PululuK !!

@SD1982 SD1982 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback Waiting for author Status: action required, waiting for author feedback labels Dec 2, 2020
@prestashop-issue-bot

prestashop-issue-bot Bot commented Dec 2, 2020

Copy link
Copy Markdown

QA OK without required approvals !? :trollface:

@Progi1984 Progi1984 merged commit afb0068 into PrestaShop:develop Dec 2, 2020
@Progi1984

Progi1984 commented Dec 2, 2020

Copy link
Copy Markdown
Member

Thanks @PululuK & @SD1982

@PululuK PululuK deleted the patch-7 branch December 2, 2020 10:14
This was referenced Dec 2, 2020
Open
Merged
@PululuK PululuK mentioned this pull request May 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpodemski kpodemski kpodemski approved these changes

@atomiix atomiix atomiix approved these changes

@Julievrz Julievrz Awaiting requested review from Julievrz

@LouiseBonnard LouiseBonnard Awaiting requested review from LouiseBonnard

@Progi1984 Progi1984 Awaiting requested review from Progi1984

@matthieu-rolland matthieu-rolland Awaiting requested review from matthieu-rolland

+1 more reviewer

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SD1982 SD1982

Labels

BC break Type: Introduces a backwards-incompatible break develop Branch Improvement Type: Improvement PM ✔️ Status: check done, behavior approved QA ✔️ Status: check done, code approved Wording ✔️ Status: check done, wording approved

Projects

None yet

Milestone

1.7.8.0

Development

Successfully merging this pull request may close these issues.

Add the language and the shop concerned in the admin logs controller

10 participants

@PululuK @prestonBot @kpodemski @PierreRambaud @Progi1984 @LouiseBonnard @Julievrz @SD1982 @matthieu-rolland @atomiix