Skip to content

Update .NET Core packages - #947

Merged
Andy Jordan (andyleejordan) merged 5 commits into
masterfrom
andschwa/update-packages
May 4, 2016
Merged

Update .NET Core packages#947
Andy Jordan (andyleejordan) merged 5 commits into
masterfrom
andschwa/update-packages

Conversation

@andyleejordan

@andyleejordan Andy Jordan (andyleejordan) commented May 4, 2016 •
edited by PowerShellTeam
Loading

Copy link
Copy Markdown
Member

This resolves #945.

Please note that I ran the type catalog generator, but there were no changes.

Also this silences some dotnet restore warnings.

This change is Reviewable

@andyleejordan

Andy Jordan (andyleejordan) commented May 4, 2016

Copy link
Copy Markdown
Member Author

This unblocks a part of #939.

@andyleejordan

Andy Jordan (andyleejordan) commented May 4, 2016

Copy link
Copy Markdown
Member Author

Jason Shirk (@lzybkr) George Fleming (@palladia) James Truher (@JamesWTruher) could you review the regression tests I added?

@palladia

George Fleming (palladia) commented May 4, 2016

Copy link
Copy Markdown
Contributor

Review status: 0 of 11 files reviewed at latest revision, 1 unresolved discussion.

test/powershell/PSReadLine.Tests.ps1, line 20 [r3] (raw file):
Should we remove-module? I know this depends on whether PSReadLine is the default or not.

Comments from Reviewable

@andyleejordan

Andy Jordan (andyleejordan) commented May 4, 2016

Copy link
Copy Markdown
Member Author

With the merge to ConsoleHost upcoming, PSReadLine will always be the default. Alternatively we could spawn another PowerShell instance for these tests.

@andyleejordan

Andy Jordan (andyleejordan) commented May 4, 2016

Copy link
Copy Markdown
Member Author

I updated the tests per James Truher (@JamesWTruher) suggestions.

@palladia

George Fleming (palladia) commented May 4, 2016

Copy link
Copy Markdown
Contributor

Reviewed 10 of 10 files at r1, 1 of 1 files at r4.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

@andyleejordan
Andy Jordan (andyleejordan) merged commit d0088c1 into master May 4, 2016
@andyleejordan
Andy Jordan (andyleejordan) deleted the andschwa/update-packages branch May 4, 2016 23:40
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@andyleejordan
Merge pull request PowerShell#947 from PowerShell/andschwa/update-pac…
8898a4e 
…kages

Update .NET Core packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

WG-Maintainers-Build specific to affecting the build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix PSReadLine for OS X

2 participants

@andyleejordan @palladia