Skip to content

Cleanup all native code from repository - #7892

Merged
Travis Plunk (TravisEz13) merged 2 commits into
PowerShell:masterfrom
adityapatwardhan:CleanupBuild
Oct 2, 2018
Merged

Cleanup all native code from repository#7892
Travis Plunk (TravisEz13) merged 2 commits into
PowerShell:masterfrom
adityapatwardhan:CleanupBuild

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Sep 28, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

Native code for PowerShell has been moved to repository PowerShell/PowerShell-Native.

Hence, removing all the native code and related build components.

PR Checklist

iSazonov
Ilya (iSazonov) reviewed Sep 29, 2018
View reviewed changes
Comment thread src/PowerShell.Core.Instrumentation/README.md Outdated

@iSazonov Ilya (iSazonov) Sep 29, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be happy to see a guidelines about new workflow for dev/debug and release. (Scenario - "I need use new Unix syscall")

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Oct 2, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have opened an issue in the powershell-native repro to track this.

PowerShell/PowerShell-Native#11

@TravisEz13

Travis Plunk (TravisEz13) commented Oct 1, 2018

Copy link
Copy Markdown
Member

The wIndows build is failing with

2018-09-28T22:57:47.5130286Z C:\Users\VssAdministrator\Appdata\Local\Microsoft\dotnet\sdk\2.1.402\Microsoft.Common.CurrentVersion.targets(4533,5): error MSB3030: Could not copy the file "D:\a\1\s\src\PowerShell.Core.Instrumentation\PowerShell.Core.Instrumentation.man" because it was not found. [D:\a\1\s\src\powershell-win-core\powershell-win-core.csproj]
2018-09-28T22:57:47.5130819Z C:\Users\VssAdministrator\Appdata\Local\Microsoft\dotnet\sdk\2.1.402\Microsoft.Common.CurrentVersion.targets(4533,5): error MSB3030: Could not copy the file "D:\a\1\s\src\powershell-native\Install-PowerShellRemoting.ps1" because it was not found. [D:\a\1\s\src\powershell-win-core\powershell-win-core.csproj]
2018-09-28T22:57:47.5131507Z C:\Users\VssAdministrator\Appdata\Local\Microsoft\dotnet\sdk\2.1.402\Microsoft.Common.CurrentVersion.targets(4533,5): error MSB3030: Could not copy the file "D:\a\1\s\src\PowerShell.Core.Instrumentation\RegisterManifest.ps1" because it was not found. [D:\a\1\s\src\powershell-win-core\powershell-win-core.csproj]

@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Oct 2, 2018

Copy link
Copy Markdown
Member Author

Travis Plunk (@TravisEz13) Issues fixed. Can you have another look?

@TravisEz13
Travis Plunk (TravisEz13) merged commit b42c001 into PowerShell:master Oct 2, 2018
@iSazonov Ilya (iSazonov) mentioned this pull request Oct 4, 2018
Closed
7 tasks
@andyleejordan Andy Jordan (andyleejordan) mentioned this pull request Nov 2, 2018
Merged
7 of 11 tasks
Andy Jordan (andyleejordan) added a commit to andyleejordan/PowerShell that referenced this pull request Nov 2, 2018
@andyleejordan
Remove build and doc references to Git submodules
62d7b36 
As of PowerShell#7892, the PowerShell repository no longer uses Git submodules.
This is fantastic from a workflow standpoint, and so all the notes about
how to deal with submodules (and all the build steps explicitly
initializing and updating submodules) can be safely removed.
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Nov 5, 2018
@andyleejordan @TravisEz13
Remove build and doc references to Git submodules (#8177)
5487418 
As of #7892, the PowerShell repository no longer uses Git submodules.
This is fantastic from a workflow standpoint, and so all the notes about
how to deal with submodules (and all the build steps explicitly
initializing and updating submodules) can be safely removed.
Aditya Patwardhan (adityapatwardhan) added a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019
@adityapatwardhan @TravisEz13
Cleanup all native code from repository (PowerShell#7892)
1e4843c 
Native code for PowerShell has been moved to repository PowerShell/PowerShell-Native.

Hence, removing all the native code and related build components.
@xtqqczze xtqqczze mentioned this pull request Jan 24, 2020
Merged
8 of 14 tasks
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan @TravisEz13
Cleanup all native code from repository (PowerShell#7892)
0156e3a 
Native code for PowerShell has been moved to repository PowerShell/PowerShell-Native.

Hence, removing all the native code and related build components.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@andyleejordan @TravisEz13
Remove build and doc references to Git submodules (PowerShell#8177)
ff7f2b8 
As of PowerShell#7892, the PowerShell repository no longer uses Git submodules.
This is fantastic from a workflow standpoint, and so all the notes about
how to deal with submodules (and all the build steps explicitly
initializing and updating submodules) can be safely removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov left review comments
@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adityapatwardhan @TravisEz13 @iSazonov