Skip to content

Fix Pull request Template Typo and Markdown Linting Error - #5807

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
markekraus:PRTemplateSpellingFix
Jan 8, 2018
Merged

Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
markekraus:PRTemplateSpellingFix

Conversation

@markekraus

@markekraus Mark Kraus (markekraus) commented Jan 6, 2018 •

Copy link
Copy Markdown
Contributor

PR Summary

  • affectes -> affects
  • Fix linting issue with comment

PR Checklist

Note: Please mark anything not applicable to this PR NA.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the PR title has a typo: Markdonw -> Markdown

@markekraus Mark Kraus (markekraus) changed the title Fix Pull request Template Typo and Markdonw Linting Error Fix Pull request Template Typo and Markdown Linting Error Jan 6, 2018
@markekraus

Copy link
Copy Markdown
Contributor Author

Christoph Bergmeister (@bergmeister) lol.. thanks.. corrected.

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 1b3d1ee into PowerShell:master Jan 8, 2018
@bergmeister

Christoph Bergmeister (bergmeister) commented Jan 8, 2018 •

Copy link
Copy Markdown
Contributor

Mark Kraus (@markekraus) It gets even better, the merge commit contains the original typo in the commit message (I always thought it was the PR title that forms the basis of the squash commit but I seem to be wrong). Nevermind, no one is going to notice/care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants