Skip to content

Add retry logic to prerequisite URL tests - #5601

Merged
Aditya Patwardhan (adityapatwardhan) merged 3 commits into
PowerShell:masterfrom
daxian-dbw:fixtest
Dec 4, 2017
Merged

Add retry logic to prerequisite URL tests#5601
Aditya Patwardhan (adityapatwardhan) merged 3 commits into
PowerShell:masterfrom
daxian-dbw:fixtest

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Dec 1, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

The package prerequisite URL tests have been failing intermittently recently, because sometimes the WMF download URLs lead to a "we're sorry, this download is no longer available" page, even though the URLs actually work in the web browser. I'm disabling those tests for now.

Close #5567

@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Dec 1, 2017

Copy link
Copy Markdown
Member

Can we try adding a simple retry before disabling?

@daxian-dbw

Dongbo Wang (daxian-dbw) commented Dec 1, 2017

Copy link
Copy Markdown
Member Author

Steve Lee (@SteveL-MSFT) Sure, I will use retries and let's see how it goes.

@daxian-dbw

Dongbo Wang (daxian-dbw) commented Dec 2, 2017

Copy link
Copy Markdown
Member Author

The failed tests are known. #5605 will make them pending for now.

@iSazonov

Ilya (iSazonov) commented Dec 3, 2017 •
edited
Loading

Copy link
Copy Markdown
Collaborator

We could run the package prerequisite URL tests with another test tag ("Doc").
Also could we run tests by demand from GitHub PR page? We could run the package prerequisite URL tests and feature tests by this way. It seems to me more comfortable - a maintainer or reviewer would run the tests without requesting the contributor and waiting.

@markekraus

Mark Kraus (markekraus) commented Dec 3, 2017

Copy link
Copy Markdown
Contributor

I'm not sure what is best for this. We need to ensure the links work, but they erroneously fail often. A retry will help sometimes, but many times when this test fails it fails for days at a time.

@daxian-dbw Dongbo Wang (daxian-dbw) changed the title Disable prerequisite URL tests Add retry logic to prerequisite URL tests Dec 4, 2017
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Dec 4, 2017
View reviewed changes

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit d105e15 into PowerShell:master Dec 4, 2017
@TravisEz13 Travis Plunk (TravisEz13) added this to the 6.0.0-RC.2 milestone Dec 5, 2017
Travis Plunk (TravisEz13) pushed a commit to TravisEz13/PowerShell that referenced this pull request Dec 5, 2017
@daxian-dbw @TravisEz13
Add retry logic to prerequisite URL tests (PowerShell#5601)
c0d5d54 
* Disable Requisiste URLs tests

* Add retry for the URL tests
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Dec 5, 2017
Merged
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Dec 5, 2017
@daxian-dbw @TravisEz13
Add retry logic to prerequisite URL tests (#5601)
926f148 
* Disable Requisiste URLs tests

* Add retry for the URL tests
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@daxian-dbw @adityapatwardhan
Add retry logic to prerequisite URL tests (PowerShell#5601)
0c2c62b 
* Disable Requisiste URLs tests

* Add retry for the URL tests
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@daxian-dbw @TravisEz13
Add retry logic to prerequisite URL tests (PowerShell#5601)
bd41165 
* Disable Requisiste URLs tests

* Add retry for the URL tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

6.0.0-RC.2

Development

Successfully merging this pull request may close these issues.

6 participants

@daxian-dbw @SteveL-MSFT @iSazonov @markekraus @adityapatwardhan @TravisEz13