Repository navigation
Update docker file for windows build - #5459
Merged
Travis Plunk (TravisEz13) merged 7 commits intoNov 28, 2017
Merged
Travis Plunk (TravisEz13) merged 7 commits into
Travis Plunk (TravisEz13) merged 7 commits into
Conversation
Travis Plunk (TravisEz13)
requested review from
Aditya Patwardhan (adityapatwardhan) and
Dongbo Wang (daxian-dbw)
as code owners
November 15, 2017 06:18
Travis Plunk (TravisEz13)
force-pushed
the
working_signing_fixes
branch
2 times, most recently
from
November 15, 2017 21:09
dc8aa12 to
efae634
Compare
There was a problem hiding this comment.
We don't need cmake anymore :)
Travis Plunk (TravisEz13)
force-pushed
the
working_signing_fixes
branch
2 times, most recently
from
November 21, 2017 21:11
e33a005 to
c6c0792
Compare
Member
Author
|
Dongbo Wang (@daxian-dbw) Aditya Patwardhan (@adityapatwardhan) Can you update your reviews? |
Member
Author
Aditya Patwardhan (adityapatwardhan)
requested changes
Nov 28, 2017
There was a problem hiding this comment.
Remove cmake comment.
There was a problem hiding this comment.
Please explain order of lookup in comments.
There was a problem hiding this comment.
Please add comment for brute force
There was a problem hiding this comment.
Please add a comment why we switched to zip instead on MSI, due to it requiring older version of dotnet
There was a problem hiding this comment.
-Force creates destination directory
There was a problem hiding this comment.
Please exclude this change from this PR.
Member
Author
There was a problem hiding this comment.
No, sorry this is a change that is needed. Saw it in reverse when I talked to you.
Travis Plunk (TravisEz13)
force-pushed
the
working_signing_fixes
branch
from
November 28, 2017 20:00
c6c0792 to
db6c02f
Compare
Member
Author
|
Verified release build |
Aditya Patwardhan (adityapatwardhan)
approved these changes
Nov 28, 2017
Travis Plunk (TravisEz13)
added a commit
to TravisEz13/PowerShell
that referenced
this pull request
Nov 29, 2017
reducing the base image size should make the build a little faster Also, remove the duplicate upload of a file
Merged
Travis Plunk (TravisEz13)
added a commit
that referenced
this pull request
Nov 29, 2017
reducing the base image size should make the build a little faster Also, remove the duplicate upload of a file
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
reducing the base image size should make the build a little faster Also, remove the duplicate upload of a file
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
reducing the base image size should make the build a little faster Also, remove the duplicate upload of a file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reducing the base image size should make the build a little faster
Also, remove the duplicate upload of a file