Skip to content

Rename to unix for installation instructions. - #5218

Closed
Greg Zimmerman (thezim) wants to merge 3 commits into
PowerShell:masterfrom
thezim:linux-to-unix
Closed

Rename to unix for installation instructions.#5218
Greg Zimmerman (thezim) wants to merge 3 commits into
PowerShell:masterfrom
thezim:linux-to-unix

Conversation

@thezim

@thezim Greg Zimmerman (thezim) commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

If we are going to group macOS with Linux installation instructions we should use the general name Unix.

@TravisEz13

Travis Plunk (TravisEz13) commented Oct 25, 2017

Copy link
Copy Markdown
Member

Joey Aiello (@joeyaiello) Can you please review?

Greg Zimmerman (@thezim) CI fail because you didn't update .spelling . https://travis-ci.org/PowerShell/PowerShell/jobs/292313955#L3205

@thezim

Greg Zimmerman (thezim) commented Oct 25, 2017

Copy link
Copy Markdown
Contributor Author

Travis Plunk (@TravisEz13) Done.

@TravisEz13

Travis Plunk (TravisEz13) commented Jan 3, 2018

Copy link
Copy Markdown
Member

Greg Zimmerman (@thezim) Sorry, I didn't follow up. Can you resolve the merge conflicts?
Steve Lee (@SteveL-MSFT) or Joey Aiello (@joeyaiello) can you review?

@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jan 3, 2018

Copy link
Copy Markdown
Member

My main concern is that Linux isn't Unix, but I don't want to get into a philosophy/religious discussion here (but my impression is that Linux hardcore fans care about the distinction). If the concern is grouping macOS with Linux, then perhaps we should split the docs keeping Linux just the OSs using the Linux kernel and a separately set for macOS?

@thezim

Greg Zimmerman (thezim) commented Jan 4, 2018

Copy link
Copy Markdown
Contributor Author

Steve Lee (@SteveL-MSFT) I agree, that was my intension, macOS != Linux. I'll close this PR an start a new one with macOS as its own set of documents.

@thezim Greg Zimmerman (thezim) mentioned this pull request Jan 8, 2018
Merged
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HemantMahawar Hemant Mahawar (HemantMahawar) Awaiting requested review from HemantMahawar
@joeyaiello Joey Aiello (joeyaiello) Awaiting requested review from joeyaiello
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thezim @TravisEz13 @SteveL-MSFT