Repository navigation
allow * to be used in registry path for remove-item - #4866
Aditya Patwardhan (adityapatwardhan) merged 3 commits into
Conversation
There was a problem hiding this comment.
Maybe it is better to skip that altogether if provider is not FileSystem provider?
e.g.: resolvedPath.Provider.Name.Equals(FileSystemProvider.ProviderName, StringComparison.OrdinalIgnoreCase)
There was a problem hiding this comment.
... that section altogether ...
There was a problem hiding this comment.
... that "DirectoryInfo code section" section altogether ...
There was a problem hiding this comment.
I agree checking for the provider seems to be a better option.
There was a problem hiding this comment.
will make the change
There was a problem hiding this comment.
Need to make sure that FileSystem paths continue to work as they were before this new catch handler; 2 tests:
- remove-item with -Path and filesystem path that contains *
- remove-item with -LiteralPath and filesystem path that contains *
There was a problem hiding this comment.
Looks like there's tests for -Path, I'll add a test for -LiteralPath with *
There was a problem hiding this comment.
Looks like the current code does nothing if you use a * with -literalpath:
remove-item -literalpath .\a*.xmlI'll fix it so it returns error when using -literalpath, but it's a breaking change
There was a problem hiding this comment.
Please add -ErrorAction SilentlyContinue -Force
There was a problem hiding this comment.
will add
There was a problem hiding this comment.
Please assign to null.
$null = New-Item -Force $testPathThere was a problem hiding this comment.
will fix
There was a problem hiding this comment.
I agree checking for the provider seems to be a better option.
|
@PowerShell/powershell-committee reviewed this and is ok with the minor |
Aditya Patwardhan (adityapatwardhan)
left a comment
There was a problem hiding this comment.
LGTM
|
Andrew (@anmenaga) Can you have a look again? |
|
Steve Lee (@SteveL-MSFT) Can you update the PR description. |
2f4ba34 to
bc5c902
Compare
a81e6f3 to
4dc5013
Compare
4dc5013 to
5a16dc4
Compare
* [feature] allow * to be used in registry path for remove-item * [feature] address PR feedback have remove-item return error if -literalpath doesn't resolve to path * [feature] fix in navigation exposed an issue with WSMan Config Provider tests that require -Recurse to be used otherwise a confirmation prompt shows up
Code is creating a DirectoryInfo instance to determine if the path is a directory or file, but it fails because
*is not allowed, however,*is a valid character in a registry path. Fix is to catch this exception and ignore it. This means that using-literalpathwith an asterisk and the filesystem provider will now return an error rather than returning quietly.Fix #4704
Fix #4330