Repository navigation
Update travis-ci script so that PRs can fail due to pester tests - #4830
Conversation
|
Travis Plunk (@TravisEz13) can you please briefly describe the issue, root cause and explain the fix? That would be helpful to the review. |
|
Dongbo Wang (@daxian-dbw) updated the description. |
f66f23f to
6a63806
Compare
There was a problem hiding this comment.
I'll add the line ending later. I'll use this change to remove the tag that forces a test failure.
There was a problem hiding this comment.
Isn't this change already done in #4807?
There was a problem hiding this comment.
I rebased and resolved the issue.
…ilure Make Test-PSPesterResults throw if there is a failure
b2ec3e2 to
1fd0c55
Compare
|
Verified tests fail correctly here: https://travis-ci.org/PowerShell/PowerShell/jobs/275168248 |
Mark Kraus (markekraus)
left a comment
There was a problem hiding this comment.
2 minor formatting comments, otherwise LGTM
| [switch]$IncludeFailingTest | ||
| ) | ||
|
|
||
| if($IncludeFailingTest.IsPresent) |
There was a problem hiding this comment.
space between if and (
There was a problem hiding this comment.
Resolved
| } | ||
|
|
||
| if($hasRunFailingTestTag) | ||
| { |
There was a problem hiding this comment.
space between if and (
There was a problem hiding this comment.
Resolved
…erShell#4830) * Add a switch to force tests to fail for testing CI system to Start-PSPester * [includeFailingTest] Add commit tag to force tests to fail for testing CI system
FYI Mark Kraus (@markekraus)
Test-PSPesterResults was expected to throw an error by the travis.ps1. It was only writing to the host.
I've updated Test-PSPesterResults to throw an error after it writes to the host.
I've also added a switch to Start-PSPester which will inject a failing test and the [includeFailingTest] in travis.ps1 which will use this switch so we can verify that it works.