Repository navigation
Move to the official .NET Core 2.0 - #4603
Conversation
Travis Plunk (TravisEz13)
left a comment
There was a problem hiding this comment.
1 Minor comment.
| # cache version - netcoreapp.2.0.0-preview3-25426-01 | ||
| # cache version - netcoreapp.2.0.0 | ||
| cache: | ||
| - '%LocalAppData%\Microsoft\dotnet -> appveyor.yml' |
There was a problem hiding this comment.
Why don't we update the caches to depend on PowerShell.Common.props. Then we only have one place to update the version.
There was a problem hiding this comment.
There are some changes pending for PowerShell.Common.props (see Ilya's MSBuild refactoring PRs). I think for the time being, PowerShell.Common.props has more churns than appveyor.yml.
Aditya Patwardhan (adityapatwardhan)
left a comment
There was a problem hiding this comment.
LGTM
|
Dongbo Wang (@daxian-dbw) This is a major change, should we run Feature tests? |
|
Aditya Patwardhan (@adityapatwardhan) I requested feature test run for the PR, please take a look at the second commit message. I will investigate failure in appveyor. |
|
There were 11 tests failing in AppVeyor and all are web cmdlet tests. They failed because of time out. |
* Migrate to official .NET Core 2.0 * [Feature] Remove chmod code as the issue has been fixed in dotnet
.NET Core 2.0 was officially released on 8/14/2017.
This PR is to migrate our tooling and build to the official .NET Core 2.0 bits.