Skip to content

Fix DeviceGuard data being returned from Get-ComputerInfo and Start-Process test failure - #4353

Merged
Travis Plunk (TravisEz13) merged 3 commits into
PowerShell:masterfrom
SteveL-MSFT:deviceguard-startprocess
Jul 28, 2017
Merged

Travis Plunk (TravisEz13) merged 3 commits into
PowerShell:masterfrom
SteveL-MSFT:deviceguard-startprocess

Conversation

@SteveL-MSFT

Copy link
Copy Markdown
Member

fix Get-ComputerInfo return of status for DeviceGuard
fix corresponding tests
this is causing one of the failures in our nightly run

fix Get-ComputerInfo return of status for DeviceGuard
fix corresponding tests
@jeffbi

jeffbi commented Jul 26, 2017

Copy link
Copy Markdown

LGTM

@SteveL-MSFT

Copy link
Copy Markdown
Member Author

CI failure is on Start-Process which is affecting nightly runs. I'm working on that today.

@SteveL-MSFT

Copy link
Copy Markdown
Member Author

jeffbi can you formally approve? thanks!

@SteveL-MSFT
Steve Lee (SteveL-MSFT) force-pushed the deviceguard-startprocess branch 2 times, most recently from 0762758 to ca13a95 Compare July 28, 2017 17:53
In CI, notepad.exe isn't starting (or starting in time) when using start-process with .txt based on file association.
Since the test is validating opening files by association, fix is to create our own association that is predictable.
@SteveL-MSFT Steve Lee (SteveL-MSFT) changed the title Fix DeviceGuard data being returned from Get-ComputerInfo Fix DeviceGuard data being returned from Get-ComputerInfo and Start-Process test failure Jul 28, 2017
@SteveL-MSFT

Copy link
Copy Markdown
Member Author

Travis Plunk (@TravisEz13) can you review the test change to Start-Process test?

@TravisEz13
Travis Plunk (TravisEz13) merged commit 06d416b into PowerShell:master Jul 28, 2017
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the deviceguard-startprocess branch July 28, 2017 21:29
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
…process

Fix DeviceGuard data being returned from Get-ComputerInfo and Start-Process test failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants