Skip to content

Add autoload for test modules - #3342

Merged
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
iSazonov:tests-auto-ipmo-1
Mar 27, 2017
Merged

Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
iSazonov:tests-auto-ipmo-1

Conversation

@iSazonov

Copy link
Copy Markdown
Collaborator

Related #3238

  1. Add autoload for test modules
  2. Move TestHostCS.psm1 to 'test\tools\Modules' folder (later we shall move the remaining modules)
  3. Remove explicit load TestHostCS.psm1 from test files

@TravisEz13

Copy link
Copy Markdown
Member

cc @PowerShell/area-test for review

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the module imports just doesn't seem right to me. If you invoke-pester directly, it doesn't even tell you what is wrong.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a new helper modules and using of existing helper modules need to be documented. I believe this is enough.

Maybe Jason Shirk (@lzybkr) has something to add.

Comment thread build.psm1 Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going to require everyone to use Start-PSPester which btw someone misnamed this function, it should be Invoke-PSPester since it is synchronous, it should have the -testname parameter.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added import of helper modules in current session too so it is not required to use Start-PSPester - it is worked well .\Out-Host.Tests.ps1

@TravisEz13

Copy link
Copy Markdown
Member

@PowerShell/area-test, Does anyone have any comments here. I left one comment on what Ilya (@iSazonov) should change if we take this and one about what is wrong with making this change.

@iSazonov Ilya (iSazonov) added the Review - Needed The PR is being reviewed label Mar 23, 2017
Related PowerShell#3238

1. Add autoload for test modules
2. Move TestHostCS.psm1 to 'test\tools\Modules\' folder
3. Remove explicit load TestHostCS.psm1 from test files
@iSazonov

Copy link
Copy Markdown
Collaborator Author

Travis Plunk (@TravisEz13) Is The PR ready to merge?

@TravisEz13
Travis Plunk (TravisEz13) merged commit a99fb53 into PowerShell:master Mar 27, 2017
@iSazonov Ilya (iSazonov) removed the Review - Needed The PR is being reviewed label Mar 27, 2017
@iSazonov
Ilya (iSazonov) deleted the tests-auto-ipmo-1 branch March 27, 2017 06:49
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Related PowerShell#3238

1. Add autoload for test modules
2. Move TestHostCS.psm1 to 'test\tools\Modules\' folder
3. Remove explicit load TestHostCS.psm1 from test files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants