New-Item -ItemType SymbolicLink cannot understand directory path ending with slash on Linux by chunqingchen · Pull Request #2974 · PowerShell/PowerShell

Chunqing Chen (chunqingchen) · 2017-01-07T04:59:06Z

Relevant issue: #2865

Steps to reproduce

New-Item -ItemType SymbolicLink -Path /foo/ -Value /bar/

Expected behavior

Symbolic link is created from /foo/ to /bar/.

Actual behavior

New-Item : No such file or directory

Removing the slash at the end of the Path argument makes the call behave as expected. This is counterintuitive, as a slash at the end of a path generally works fine in PowerShell scripts to designate directories (and directory links).

Environment data

Running PowerShell on Ubuntu 16.04.

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.0.0-alpha
PSEdition                      Core
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   3.0.0.0
GitCommitId                    v6.0.0-alpha.12
CLRVersion
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Mike Richmond (mirichmo)

Please include tests for this change

Mike Richmond (mirichmo) · 2017-02-17T00:19:12Z

Chunqing Chen (@chunqingchen) Ping

Chunqing Chen (chunqingchen) · 2017-03-28T21:51:40Z

Mike Richmond (@mirichmo) the tests are added.

Mike Richmond (mirichmo) · 2017-03-28T22:20:20Z

Chunqing Chen (@chunqingchen) Thank you. Please assign appropriate reviewer(s) to review this change

Chunqing Chen (chunqingchen) · 2017-03-28T23:03:27Z

Francisco Gamino (@Francisco-Gamino) hi Francisco, it seems you have reviewed the code file recently. Would you mind help me review this change? Thank you~

Francisco Gamino (Francisco-Gamino) · 2017-04-05T14:53:28Z

This should probably be:

Get-Item "$tmpDirectory/$folderName/" -ErrorAction SilentlyContinue | remove-item -force -recurse -ErrorAction SilentlyContinue

Unfortunately remove-item would not work here because the item is a symboliclink path. It will lead to a System.ComponentModel.Win32Exception.

if these are all created in $TESTDRIVE, there's no clean up needed at all, as pester will take care of it
Also, please fix spelling error Directoy => Directory

In reply to: 110466085 [](ancestors = 110466085)

Chunqing Chen (@chunqingchen): Good to know. Thanks.

Francisco Gamino (Francisco-Gamino) · 2017-04-05T14:58:00Z

Should we specified in the comment that Path.AltDirectorySeparatorChar referred to ('') on UNIX and a slash ('/') on Windows and Mac?

James Truher (JamesWTruher) · 2017-04-07T19:41:04Z

resolvePath [](start = 20, length = 11)

I'm not sure that this can be so simple, are we guaranteed that the order will be this? For example, will we'll always get "", and then "/"?

Chunqing Chen (chunqingchen) · 2017-04-10T22:44:09Z

Francisco Gamino (@Francisco-Gamino) Thanks Francisco for the review, the comments are resolved.

Chunqing Chen (chunqingchen) · 2017-04-10T22:44:34Z

James Truher (@JamesWTruher) Thanks Jim for the review, the comment has been resolved

Francisco Gamino (Francisco-Gamino) · 2017-04-13T17:04:20Z

You have an extra space before ' '
char[] charsToTrim = {<extra_pace>' '...

Francisco Gamino (Francisco-Gamino) · 2017-04-13T17:06:43Z

Chunqing Chen (@chunqingchen): Just one minor comment. Other than that, it LGTM.

Chunqing Chen (chunqingchen) · 2017-04-14T22:14:18Z

Francisco Gamino (@Francisco-Gamino) the space is removed. thanks !

Chunqing Chen (chunqingchen) · 2017-04-14T23:46:56Z

Mike Richmond (@mirichmo) can you merge now?

Mike Richmond (mirichmo) · 2017-04-18T22:03:13Z

Directoy --> Directory

…ng with slash on Linux

…ng with slash on Linux (PowerShell#2974)

Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Jan 7, 2017

PowerShellTeam added the Review - Needed The PR is being reviewed label Jan 9, 2017

Mike Richmond (mirichmo) suggested changes Jan 12, 2017

View reviewed changes

Mike Richmond (mirichmo) added Review - Waiting on Author and removed Review - Needed The PR is being reviewed labels Feb 9, 2017

PowerShellTeam added Review - Needed The PR is being reviewed and removed Review - Waiting on Author labels Feb 9, 2017

Mike Richmond (mirichmo) added Review - Waiting on Author and removed Review - Needed The PR is being reviewed labels Feb 17, 2017

Dongbo Wang (daxian-dbw) assigned Mike Richmond (mirichmo) Feb 17, 2017

Chunqing Chen (chunqingchen) removed the Review - Waiting on Author label Mar 28, 2017

Chunqing Chen (chunqingchen) requested a review from Francisco Gamino (Francisco-Gamino) March 28, 2017 23:01

Francisco Gamino (Francisco-Gamino) suggested changes Apr 5, 2017

View reviewed changes

James Truher (JamesWTruher) reviewed Apr 7, 2017

View reviewed changes

Francisco Gamino (Francisco-Gamino) reviewed Apr 13, 2017

View reviewed changes

Francisco Gamino (Francisco-Gamino) approved these changes Apr 13, 2017

View reviewed changes

Mike Richmond (mirichmo) suggested changes Apr 18, 2017

View reviewed changes

New-Item -ItemType SymbolicLink cannot understand directory path endi…

0f16c00

…ng with slash on Linux

Mike Richmond (mirichmo) approved these changes Apr 18, 2017

View reviewed changes

Mike Richmond (mirichmo) merged commit e3d4c95 into PowerShell:master Apr 18, 2017

Chunqing Chen (chunqingchen) mentioned this pull request Apr 18, 2017

New-Item -ItemType SymbolicLink cannot understand directory path ending with slash on Linux #2865

Closed

Steve Lee (SteveL-MSFT) mentioned this pull request Apr 26, 2017

Symlinks cause weirdness related to trailing slash #1775

Closed

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026

New-Item -ItemType SymbolicLink cannot understand directory path endi…

fe6a65d

…ng with slash on Linux (PowerShell#2974)

Conversation

Chunqing Chen (chunqingchen) commented Jan 7, 2017 • edited by joeyaiello Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mike Richmond (mirichmo) left a comment

Choose a reason for hiding this comment

Uh oh!

Mike Richmond (mirichmo) commented Feb 17, 2017

Uh oh!

Chunqing Chen (chunqingchen) commented Mar 28, 2017

Uh oh!

Mike Richmond (mirichmo) commented Mar 28, 2017

Uh oh!

Chunqing Chen (chunqingchen) commented Mar 28, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Chunqing Chen (chunqingchen) commented Apr 10, 2017

Uh oh!

Chunqing Chen (chunqingchen) commented Apr 10, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Francisco Gamino (Francisco-Gamino) commented Apr 13, 2017

Uh oh!

Chunqing Chen (chunqingchen) commented Apr 14, 2017

Uh oh!

Chunqing Chen (chunqingchen) commented Apr 14, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Chunqing Chen (chunqingchen) commented Jan 7, 2017 •

edited by joeyaiello

Loading