Skip to content

Disable PackageManagementTests - #2703

Closed
Aditya Patwardhan (adityapatwardhan) wants to merge 1 commit into
PowerShell:masterfrom
adityapatwardhan:PackageManagementTestDisable
Closed

Aditya Patwardhan (adityapatwardhan) wants to merge 1 commit into
PowerShell:masterfrom
adityapatwardhan:PackageManagementTestDisable

Conversation

@adityapatwardhan

Copy link
Copy Markdown
Member

Package management tests disabled temporarily to unblock daily builds.

Package management tests disabled temporarily to unblock daily builds.
@adityapatwardhan

Copy link
Copy Markdown
Member Author

Jianyun (@jianyunt) Dongbo Wang (@daxian-dbw) Can you have a look?

@vors

Copy link
Copy Markdown
Collaborator

I think it's better to use a file-level try-finally to disable them.
We had a similar discussion in #2335 and agreed that BeforeAll/AfterAll disabling is too verbose, if we do it for the whole file.

@daxian-dbw

Dongbo Wang (daxian-dbw) commented Nov 17, 2016 •

Copy link
Copy Markdown
Member

Aditya Patwardhan (@adityapatwardhan) If we are just temporarily disabling those tests, wouldn't it be much easier to just return at the beginning of those test files? And then it would also be much easier to re-enable those tests after moving them to oneget.org (just remove the return at the beginning of each test file).

@vors

Copy link
Copy Markdown
Collaborator

Dongbo Wang (@daxian-dbw) that way we get reporting about skipped / pending tests and it's useful.

@daxian-dbw

Copy link
Copy Markdown
Member

sergei (@vors) Yes, but we are removing them from PS/PS, so it's doesn't matter that we don't keep track of skipping/pending for them. BTW, I chatted with Aditya Patwardhan (@adityapatwardhan) and learnt that Jianyun (@jianyunt) asked him to directly delete those tests from PS/PS, which is even better.

@mirichmo

Copy link
Copy Markdown
Member

"Waiting on author" then?

@vors

Copy link
Copy Markdown
Collaborator

Tests are deleted in the different PR.
I think this PR is obsolete now.

@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the PackageManagementTestDisable branch May 3, 2017 17:20
@TravisEz13 Travis Plunk (TravisEz13) added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Waiting on Author labels May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants