Skip to content

Fixing the Win10 sdk presence check - #2568

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
mirichmo:fixing-win10-sdk-check
Oct 31, 2016
Merged

Fixing the Win10 sdk presence check#2568
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
mirichmo:fixing-win10-sdk-check

Conversation

@mirichmo

@mirichmo Mike Richmond (mirichmo) commented Oct 31, 2016

Copy link
Copy Markdown
Member

The existing Windows 10 SDK check is not sufficient because the directory it checks is present even if the SDK is not installed. I made the check more specific to the SDK to tighten the check and enable installation via chocolatey during Start-PSBootstrap -Package.

@msftclas

Microsoft Contribution License Agreements (msftclas) commented Oct 31, 2016

Copy link
Copy Markdown

Hi Mike Richmond (@mirichmo), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Mike Richmond). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

daxian-dbw
Dongbo Wang (daxian-dbw) requested changes Oct 31, 2016
View reviewed changes
Comment thread build.psm1 Outdated

@daxian-dbw Dongbo Wang (daxian-dbw) Oct 31, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$win10sdkBinPath declared but not used in Start-PSBootstrap. Can you please remove it?

@mirichmo Mike Richmond (mirichmo) Oct 31, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment thread build.psm1 Outdated

@daxian-dbw Dongbo Wang (daxian-dbw) Oct 31, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not directly search ${env:ProgramFiles(x86)}\Windows Kits\10\bin\x64?

@mirichmo Mike Richmond (mirichmo) Oct 31, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy and paste issue. That check is overkill for now, so I can simplify it.

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 9b478dd into PowerShell:master Oct 31, 2016
@mirichmo
Mike Richmond (mirichmo) deleted the fixing-win10-sdk-check branch October 31, 2016 22:10
@mirichmo Mike Richmond (mirichmo) mentioned this pull request Nov 3, 2016
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@mirichmo @daxian-dbw
Fixing the Win10 sdk presence check (PowerShell#2568)
398011b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mirichmo @msftclas @daxian-dbw