Fix ConvertTo-Html single matched column header bug by TimCurwick · Pull Request #2184 · PowerShell/PowerShell

Tim Curwick (TimCurwick) · 2016-09-04T15:43:26Z

Fix ConvertTo-Html single matched column header bug
Add ConvertTo-Html pester tests for single matched column header bug

Fix ConvertTo-Html single matched column header bug Add ConvertTo-Html pester tests for single matched column header bug

Microsoft Contribution License Agreements (msftclas) · 2016-09-04T15:43:30Z

Hi Tim Curwick (@TimCurwick), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

Tim Curwick (TimCurwick) · 2016-09-04T16:23:24Z

Fixes issue #2185
There were no tests for ConvertTo-Html. I added a test file with two tests specific to the modified behavior. I presume Microsoft has other, existing tests for ConvertTo-Html that can and should also be run before merging.

Sebastian N. (megamorf) · 2016-09-05T19:26:55Z


    [Cmdlet(VerbsData.ConvertTo, "Html", DefaultParameterSetName = "Page",
-        HelpUri = "https://go.microsoft.com/fwlink/?LinkID=113290", RemotingCapability = RemotingCapability.None)]
+        HelpUri = "http://go.microsoft.com/fwlink/?LinkID=113290", RemotingCapability = RemotingCapability.None)]


Could you revert this to https please. TLS connections should be the default for URLs.

Mike Richmond (mirichmo) · 2016-09-08T17:28:41Z

Aditya Patwardhan (@adityapatwardhan) Please take a look. This fix is specific to Windows PowerShell (full CLR) because the cmdlet has not yet been ported to CoreCLR.

Aditya Patwardhan (adityapatwardhan) · 2016-09-09T17:21:19Z

+    $customPSObject = [pscustomobject]@{ "prop1" = "val1"; "prop2" = "val2" } 
+
+    It "Test ConvertTo-Html header with default single property" -Skip:( $IsLinux -or $IsOSX -or $IsCoreCLR ) {
+        $returnObject = $customPSObject | Select prop1 | ConvertTo-Html


Select [](start = 42, length = 6)

Do not use aliases in tests. Use select-object instead.

Aditya Patwardhan (adityapatwardhan) · 2016-09-21T16:58:05Z

Tim Curwick (@TimCurwick) please fix the two small comments in the tests. Rest looks good.

Dongbo Wang (daxian-dbw) · 2016-10-13T21:40:56Z

Tim Curwick (@TimCurwick) could you please address the 2 comments and rebase your commits? ConvertTo-Html has been enabled in powershell core.

Tim Curwick (TimCurwick) · 2016-11-11T19:59:20Z

Sorry about the delay. I was on vacation and then busy with the Summit. Airports are great for catching up on work. :)

Aditya Patwardhan (adityapatwardhan) · 2016-11-11T20:00:25Z

Tim Curwick (@TimCurwick) Seems that there are merge conflicts in test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertTo-Html.Tests.ps1. Could you resolve those please?

Aditya Patwardhan (adityapatwardhan) · 2016-11-11T21:35:33Z

Tim Curwick (@TimCurwick) Commit# 6b1ecd4 also has merge conflicts.

Chunqing Chen (chunqingchen) · 2017-01-11T01:46:14Z

please resolve the build conflict. It's still there

Mike Richmond (mirichmo) · 2017-03-30T01:15:44Z

I am trying to clean out old PRs and this one looks potentially useful.

James Truher (@JamesWTruher) or Dan Travison (@dantraMSFT) - Can one or both of you review this change and provide feedback? Also, please confirm that it is still relevant and has not already been fixed.

If you guys approve of it, I'll guide it in for a landing.

James Truher (JamesWTruher) · 2017-05-18T00:06:47Z

+
+    function normalizeLineEnds([string]$text)
+    {
+        $text -replace "`r`n?|`n", "`r`n"


$text -replace "${newLine}?|`n","${newLine}"

might be better, or could the line endings be removed entirely? Is that part of what you're looking to validate?

James Truher (JamesWTruher) · 2017-05-18T00:09:30Z

+<title>HTML TABLE</title>
+</head><body>
+<table>
+<colgroup><col/><col/><col/></colgroup>


i sure wish we could replicate less code - create variables and reuse them?

James Truher (JamesWTruher) · 2017-05-18T00:19:25Z

+
+    It "Test ConvertTo-Html with no parameters" {
+        $returnObject = $customObject | ConvertTo-Html
+        $returnObject -is [System.Array] | Should Be $true


this test isn't really needed, right? isn't the test on line 30 enough?

I think the test is appropriate; however, it would be easier to diagnose if Type.FullName is compared instead of a soft-cast.

Should Be $true is an anti-pattern - the logs aren't very useful so try to avoid that.

In this case, you can use 'Should BeOfType`. See the list of Pester assertions here.

And I'll be honest - I'm surprised it's an array - I would have expected a single string, so from that point of view, it might be worth a test to at least make it obvious if someone were to implement my expected behavior.

mi-hol · 2017-06-27T17:03:19Z

Tim Curwick (@TimCurwick) are you planning to implemented the requested changes?
James Truher (@JamesWTruher) should the label 'Review - needed' be replaced with another one?

Mike Richmond (mirichmo) · 2017-07-18T20:50:02Z

I replaced this PR with PR #4276

Fix ConvertTo-Html single matched column header bug

2b3f793

Fix ConvertTo-Html single matched column header bug Add ConvertTo-Html pester tests for single matched column header bug

Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label Sep 4, 2016

Update convert-HTML.cs

3ff33ec

Travis Plunk (TravisEz13) added the Review - Needed label Sep 5, 2016

megamorf reviewed Sep 5, 2016
View reviewed changes

Mike Richmond (mirichmo) assigned Aditya Patwardhan (adityapatwardhan) Sep 8, 2016

adityapatwardhan reviewed Sep 9, 2016
View reviewed changes

Mike Richmond (mirichmo) added Review - Waiting on Author and removed Review - Needed labels Sep 12, 2016

Travis Plunk (TravisEz13) added Review - Needed and removed Review - Waiting on Author labels Sep 12, 2016

Mike Richmond (mirichmo) added Review - Waiting on Author and removed Review - Needed labels Sep 13, 2016

Travis Plunk (TravisEz13) added Review - Needed and removed Review - Waiting on Author labels Sep 13, 2016

Aditya Patwardhan (adityapatwardhan) added Review - Waiting on Author and removed Review - Needed labels Sep 14, 2016

Travis Plunk (TravisEz13) added Review - Needed and removed Review - Waiting on Author labels Sep 15, 2016

Aditya Patwardhan (adityapatwardhan) added Review - Waiting on Author and removed Review - Needed labels Sep 20, 2016

PowerShellTeam added Review - Needed and removed Review - Waiting on Author labels Nov 10, 2016

Travis Plunk (TravisEz13) added the Review - Abandoned label Nov 10, 2016

PowerShellTeam added the Review - Needed label Nov 10, 2016

Travis Plunk (TravisEz13) added Review - Abandoned and removed Review - Needed labels Nov 10, 2016

PowerShellTeam added the Review - Abandoned label Nov 10, 2016

Replaced aliases in ConvertTo-HTML.tests.ps1

8aa1772

Resolved conflicts

6b1ecd4

Travis Plunk (TravisEz13) added cla-already-signed and removed Review - Abandoned labels Nov 12, 2016

PowerShellTeam added Stale and removed Review - Waiting on Author labels Nov 25, 2016

PowerShellTeam added the Review - Needed The PR is being reviewed label Jan 11, 2017

Travis Plunk (TravisEz13) removed the Stale label Feb 16, 2017

Mike Richmond (mirichmo) assigned Mike Richmond (mirichmo) and unassigned Aditya Patwardhan (adityapatwardhan) Mar 30, 2017

Mike Richmond (mirichmo) requested review from James Truher (JamesWTruher) and Dan Travison (dantraMSFT) March 30, 2017 01:16

James Truher (JamesWTruher) reviewed May 18, 2017

View reviewed changes

Mike Richmond (mirichmo) mentioned this pull request Jul 17, 2017

Fix ConvertTo-Html single matched column header bug #4276

Merged

Mike Richmond (mirichmo) closed this Jul 18, 2017

Conversation

Tim Curwick (TimCurwick) commented Sep 4, 2016

Uh oh!

Microsoft Contribution License Agreements (msftclas) commented Sep 4, 2016

Uh oh!

Tim Curwick (TimCurwick) commented Sep 4, 2016 • edited by adityapatwardhan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sebastian N. (megamorf) Sep 5, 2016

Choose a reason for hiding this comment

Uh oh!

Mike Richmond (mirichmo) commented Sep 8, 2016

Uh oh!

Aditya Patwardhan (adityapatwardhan) Sep 9, 2016

Choose a reason for hiding this comment

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Sep 21, 2016

Uh oh!

Dongbo Wang (daxian-dbw) commented Oct 13, 2016

Uh oh!

Tim Curwick (TimCurwick) commented Nov 11, 2016

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Nov 11, 2016

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Nov 11, 2016

Uh oh!

Chunqing Chen (chunqingchen) commented Jan 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mike Richmond (mirichmo) commented Mar 30, 2017

Uh oh!

James Truher (JamesWTruher) May 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

James Truher (JamesWTruher) May 18, 2017

Choose a reason for hiding this comment

Uh oh!

James Truher (JamesWTruher) May 18, 2017

Choose a reason for hiding this comment

Uh oh!

Dan Travison (dantraMSFT) May 18, 2017

Choose a reason for hiding this comment

Uh oh!

Jason Shirk (lzybkr) May 18, 2017

Choose a reason for hiding this comment

Uh oh!

mi-hol commented Jun 27, 2017

Uh oh!

Mike Richmond (mirichmo) commented Jul 18, 2017

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Tim Curwick (TimCurwick) commented Sep 4, 2016 •

edited by adityapatwardhan

Loading

Chunqing Chen (chunqingchen) commented Jan 11, 2017 •

edited

Loading

James Truher (JamesWTruher) May 18, 2017 •

edited

Loading