Repository navigation
Update install-powershell.ps1 with more options - #19884
Ryan Yates (kilasuit) wants to merge 14 commits into
Conversation
|
Minor additional formatting changes were included whilst editing the script but does not impact use Tested with the following which all work as expected .\tools\install-powershell.ps1 -Destination C:\ps -Version '7.3.1' -VerboseUnzips to C:\ps-7.3.1\ and informs the user on this .\tools\install-powershell.ps1 -Version 'v7.3.1' -VerboseUnzips to $env:LOCALAPPDATA\Microsoft\powershell-7.3.1\ and informs the user on this .\tools\install-powershell.ps1 -Destination C:\ps -LTS -VerboseUnzips to C:\ps-LTS\ and informs the user on this |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
Ryan Yates (@kilasuit) The "PowerShell-CI-install-ps" job failed, which is likely caused by the changes in this PR. Please take a look. |
|
Dongbo Wang (@daxian-dbw) I have looked and can't see why my changes could cause the jobs to fail (minor edit) Travis Plunk (@TravisEz13) or at least that I think I can fix as the error message is pointing to an issue as listed below (hope saves you from digging) |
|
Currently working on this with updating the parameter sets properly - will push another update with this in the coming days |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
2 similar comments
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
Travis Plunk (@TravisEz13) Please review again when you get the time. Thanks! |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
1 similar comment
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
/azp run PowerShell-CI-Windows |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run PowerShell-CI-install-ps |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run PowerShell-CI-install-ps |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run PowerShell-CI-install-ps |
|
Azure Pipelines successfully started running 1 pipeline(s). |
efead85 to
264819d
Compare
|
📣 Hey Ryan Yates (@kilasuit), how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
|
I am abandoning this PR but am continuing with this work & will raise a fresh PR to review this week. |
PR Summary
Adds additional parameters into the install-powershell.ps1 script for use with installing LTS or a specific version as passed through
Also updates the readme for this script.
Fixes #15403
Fixes #19883
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).