Skip to content

Fix share completion with provider and spaces - #19440

Merged
Ilya (iSazonov) merged 9 commits into
PowerShell:masterfrom
MartinGC94:FixShareCompletion
Feb 25, 2025
Merged

Ilya (iSazonov) merged 9 commits into
PowerShell:masterfrom
MartinGC94:FixShareCompletion

Conversation

@MartinGC94

Copy link
Copy Markdown
Contributor

PR Summary

Stops the regex pattern for fileshares from (incorrectly) finding Windows device paths.
Makes the list item/tooltip text for fileshare completions consistent with normal path completion behavior.
Fixes tab completion for share names when specifying the filesystem provider like this: Microsoft.PowerShell.Core\FileSystem::\\localhost\<Tab> previously you would get no results.

Also fixes tab completion for file shares which are currently not quoted as they should when they contain spaces.
I have a question about adding a test share for this scenario. Can I just do it? Do I need to do anything special with the share ACL?

PR Context

Fixes #7569
Fixes #10002

PR Checklist

@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Apr 3, 2023
@ghost ghost added the Review - Needed The PR is being reviewed label Apr 12, 2023
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@daxian-dbw Dongbo Wang (daxian-dbw) added WG-Engine core PowerShell engine, interpreter, and runtime Needs-Triage The issue is new and needs to be triaged by a work group. labels May 1, 2023
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels May 15, 2023
@ghost ghost added the Review - Needed The PR is being reviewed label May 24, 2023
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 26 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +19 -7
Percentile : 10.4%

Total files changed: 2

Change summary by file extension:
.cs : +16 -7
.ps1 : +3 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@StevenBucher98 Steven Bucher (StevenBucher98) added the PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update label Jun 5, 2023
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Review - Needed The PR is being reviewed label Mar 4, 2024
@JamesWTruher

Copy link
Copy Markdown
Collaborator

The @PowerShell/wg-powershell-engine discussed this and believe this change to be proper from a behavioral perspective.

@JamesWTruher James Truher (JamesWTruher) removed the Needs-Triage The issue is new and needs to be triaged by a work group. label Mar 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot added Review - Needed The PR is being reviewed labels Mar 12, 2024
@rkeithhill Keith Hill (rkeithhill) added the WG-Reviewed A Working Group has reviewed this and made a recommendation label Jul 7, 2024
@JamesWTruher James Truher (JamesWTruher) removed their assignment Nov 15, 2024
@iSazonov

Copy link
Copy Markdown
Collaborator

Stops the regex pattern for fileshares from (incorrectly) finding Windows device paths.

So follow will do not work?

Get-ChildItem -Path \\.\C:\<tab>

@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Review - Needed The PR is being reviewed label Feb 18, 2025
@iSazonov

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@MartinGC94

Copy link
Copy Markdown
Contributor Author

I guess creating the share requires admin rights. Do you have a preferred way for me to skip this test when not elevated, or should I just add the classic:

using namespace System.Security.Principal
!([WindowsPrincipal][WindowsIdentity]::GetCurrent()).IsInRole([WindowsBuiltInRole]::Administrator)

to the skip parameter for the test?

@iSazonov

Copy link
Copy Markdown
Collaborator

MartinGC94 There are CIs with elevated rights. Please use:

Describe "....." -Tag @('CI', 'RequireAdminOnWindows',) {

@iSazonov

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@iSazonov
Ilya (iSazonov) dismissed Steve Lee (SteveL-MSFT)’s stale review February 25, 2025 07:01

Request for new tests was resolved.

@iSazonov
Ilya (iSazonov) merged commit d6b5e5e into PowerShell:master Feb 25, 2025
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Mar 25, 2025
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log Extra Small PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update WG-Engine core PowerShell engine, interpreter, and runtime WG-Reviewed A Working Group has reviewed this and made a recommendation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tab completion of a provider path notation UNC share name is not possible path completion of unc paths with spaces fails to quote resulting path

9 participants