Make a minor update to the FileInfo table formatting on Unix to make it more concise#18183
Merged
Merged
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
iSazonov
approved these changes
Sep 29, 2022
iSazonov
left a comment
Collaborator
There was a problem hiding this comment.
LGTM with one minor comment.
22 tasks
22 tasks
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Make a minor update to the
FileInfotable formatting on Unix to make it a little more concise.The existing formatting has too much blank space in the table, which makes it a little hard to quick scan the file name column, which is at the right most.
A few changes to the view:
Usercolumn, so thatUserandGroupare closely together.UserandGroupto be 10 instead of 16. The old limit to username (like in Ubuntu 11.04) was 8 characters, and now the limit is 32 characters. I did a search on common Linux usernames, and most of the names I found falls under 10 characters. So, change the width to be 10 instead of 16 to reduce blank spaces of the table view.LastWriteTimeuses a fixed format for this view, so we can use the exact width, which is 16.Sizecolumn or (length), using width 12 will allow us to show a file size of931 gbwithout truncating, which should be sufficient in most cases.PR Context
Before the change:
After the change:
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.