Skip to content

Ability to pass InitialSessionState to UnmangedPSEntry.Start - #17319

Closed
Staffan Gustafsson (powercode) wants to merge 5 commits into
PowerShell:masterfrom
powercode:unmanaged_start
Closed

Staffan Gustafsson (powercode) wants to merge 5 commits into
PowerShell:masterfrom
powercode:unmanaged_start

Conversation

@powercode

@powercode Staffan Gustafsson (powercode) commented May 12, 2022 •

Copy link
Copy Markdown
Collaborator

Adds an overload to UnmangedPSEntry.Start that accepts an InitialSessionState object, on par with the overloads for ConsoleShell.

PR Summary

Give more flexibility for custom hosts.

PR Context

PR Checklist

Adds an overload to UnmangedPSEntry.Start that accepts an InitialSessionState object, on par with the overloads for ConsoleShell.

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some passed in args may not be respected when the InitialSessionState is created before Start, the first one pops in my mind is -SettingsFile, which is supposed to overwrite the powershell.config.json at $pshome, but settings in that file may have been used already before calling Start.

What is the scenario for using this new overload?

Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
@powercode

Staffan Gustafsson (powercode) commented May 13, 2022 •

Copy link
Copy Markdown
Collaborator Author

In a custom, internal, PowerShell distribution, I need to have a couple of base assemblies/modules loaded in the initial session even when starting without a profile.

My idea was to replace pwsh.exe with my own version, that creates an initial session state with those assemblies/modules.

If there is an alternative way to achieve this, I'm all ears!

I also want to setup a ServiceProvider to enable dependency injection, and that could also be provided there.

@powercode

Copy link
Copy Markdown
Collaborator Author

For reference: #17349

@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 5 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +3 -2
Percentile : 2%

Total files changed: 1

Change summary by file extension:
.cs : +3 -2

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbw

Copy link
Copy Markdown
Member

My idea was to replace pwsh.exe with my own version,

You must have evaluated ConsoleShell, which already takes an InitialSessionState instance. Why does it not work for your scenario?

@powercode

Copy link
Copy Markdown
Collaborator Author

You must have evaluated ConsoleShell, which already takes an InitialSessionState instance. Why does it not work for your scenario?

Embarrassed to admit that I had missed ConsoleShell 😳.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants