Repository navigation
Side-by-side Unix packages - #1717
Conversation
|
Andy Jordan (@andschwa) Can you include license.txt as part of the package? Joey Aiello (@joeyaiello) Do we need to include ThirdPartyNotices.txt in the package? |
|
Raghu Shantha (@raghushantha) Per 4eea68f the license is included in every copy of the build (and so included int he package). |
|
Andy Jordan (@andschwa) Great. |
Rather than including it only at packaging, we should include this license as part of `dotnet build` and `dotnet publish`.
Moved Unix package code into New-UnixPackage, switching on $Types to call the appropriate function given the list of types. Also fixed bug with chmod on a symlink; it was unnecessary.
The DLLs should not be marked executable on Unix. Also remove deb-build-depends as the `dotnet` package is not yet universally available.
|
Now also resolves #1433. |
|
License needs to be in the repo, in the EULA in the MSI installer, and in the root of every package. Binary dependencies need to be in the MSI installer, and the root of every package. Third party notices (the ones applicable to source code) need to be in the root of the repository. Make sense? |
|
Joey Aiello (@joeyaiello) for binary dependencies, can you give me a document for that? |
|
Andy Jordan (@andschwa) we don't have it yet. When I do, you guys will be the first to know |
|
No worries. Raghu Shantha (@raghushantha), Joey Aiello (@joeyaiello) can I get a sign off? |
|
16.04 package built and tested. |
|
Andy Jordan (@andschwa) I tested this on Ubuntu 16.04, and it works like a charm! |
|
|
|
Yay! |
|
For what it's worth, I tested both the package and also building on 16.04. Everything worked fine, |
Side-by-side Unix packages
origin/master.First go at implementing the side-by-side Unix package design detailed here. I've tested and it's working. I still need to update a bunch of documentation regarding this, but wanted a review.
Please take a look and test Raghu Shantha (@raghushantha).