Fixing get-help on Linux - #1695

Describe 'Basic help system tests' -Tags "CI" {

Does this need to be in CI scope? #Closed

Refers to: test/powershell/engine/HelpSystem.Tests.ps1:1 in 529594e. [](commit_id = 529594eb5efb8b249101e28dae6cf204dc69fc6b, deletion_comment = False)

🕐

Aditya Patwardhan (@adityapatwardhan) all tests should begin at CI scope until found to be overly slow and low risk.

Especially considering we have 13 non CI test regressions already.

LGTM

Aditya Patwardhan (@adityapatwardhan) --For the Windows scenario, we need to install the help files for Microsoft.PowerShell.Core. Should I added the files via nuget package (this is the Linux scenario because update-help does not work)? or should I call update-help -module microsoft.powershell.core?

Aditya Patwardhan (@adityapatwardhan) The main issue on Linux is that update-help does not work, so this is the reason why we created the nuget package with the help files. For windows on the other hand, I was thinking to download the help content for Microsoft.PowerShell.Core and check in with the tests. Then, when the tests are run, on Windows, we will call update-help -sourcepath . This way, we do not have to make a call outside. Thoughts?

So how does .NET Core restore NuGet pkgs? I know they don't use nuget.exe because I've seen issues on why that isn't cross-plat. But somewhere, someone on .NET Core has implemented the ability to at least pull pkgs from NuGet. Any chance the team could get their hands on that code?

Keith Hill (@rkeithhill) That's the funny thing, it does use NuGet! The command is dotnet restore but it actually invokes NuGet underneath, which is indeed cross platform.

Aditya Patwardhan (@adityapatwardhan) I've update the tests to install the help content using -sourcepath for CI, and update-help making a call to the download center for Feature tests.

LGTM

Andy Jordan (@andschwa) could you please integrate this PR when you have a moment? Thanks!

Checked with Francisco Gamino (@Francisco-Gamino) about the binary file. It's a quarter of a megabyte and unlikely to change frequently, so I'm okay committing it. It's a test asset that does not need to kept up-to-date and is simply to ensure CI can pass without fail (i.e. no transient networking problems).