Skip to content

Adding Man Page For PowerShell - #1666

Merged
Andy Jordan (andyleejordan) merged 1 commit into
masterfrom
ealexjordan/manps
Aug 10, 2016
Merged

Andy Jordan (andyleejordan) merged 1 commit into
masterfrom
ealexjordan/manps

Conversation

@ealexjordan

@ealexjordan A (ealexjordan) commented Aug 5, 2016 •

Copy link
Copy Markdown
Contributor

Just added the help page from the Windows side temporarily.

@ealexjordan
A (ealexjordan) force-pushed the ealexjordan/manps branch 2 times, most recently from 91949da to 93ba0dc Compare August 5, 2016 23:08
@TravisEz13

Travis Plunk (TravisEz13) commented Aug 6, 2016 •

Copy link
Copy Markdown
Member

Please use the present tense (instead of present participle), imperative style for commit messages and title per Contribution Guide.
Updated PR title to match guidance.

Comment thread build.psm1 Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line now contains 3 spaces. Please, revert

@vors

Copy link
Copy Markdown
Collaborator

LGTM

@TravisEz13 Travis Plunk (TravisEz13) added the Area-Maintainers-Documentation specific to documentation in this repo label Aug 7, 2016
Comment thread build.psm1 Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add it here, it should only be added under if ($Package).

Comment thread build.psm1 Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be here. The deployment of the gzip file should be done by the package, not by the package creator.

@andyleejordan

Copy link
Copy Markdown
Member

Man page! :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Maintainers-Documentation specific to documentation in this repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants