Skip to content

Use Microsoft.PowerShell.MarkdownRender package from nuget.org - #14090

Merged
Rob Holt (rjmholt) merged 3 commits into
PowerShell:masterfrom
adityapatwardhan:RemoveMarkRender
Dec 9, 2020
Merged

Use Microsoft.PowerShell.MarkdownRender package from nuget.org#14090
Rob Holt (rjmholt) merged 3 commits into
PowerShell:masterfrom
adityapatwardhan:RemoveMarkRender

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Nov 13, 2020

Copy link
Copy Markdown
Member

PR Summary

The code for Microsoft.PowerShell.MarkdownRender has been moved to a separate repository https://github.com/powershell/markdownrender. This PR removes the code from this repository and uses the package from nuget.org instead

PR Context

PR Checklist

@xtqqczze

xtqqczze commented Nov 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

I see the initial commit PowerShell/MarkdownRender@345e2f3 was on 2020-10-02. We should ensure changes made in the last few months are reflected in powershell/markdownrender:

TravisEz13
Travis Plunk (TravisEz13) requested changes Nov 19, 2020
View reviewed changes
Comment thread tools/packaging/packaging.psm1 Outdated

@TravisEz13 Travis Plunk (TravisEz13) Nov 19, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be signed in your build, so can you remove it from our signing?

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 19, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 20, 2020
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Nov 20, 2020

Copy link
Copy Markdown
Member Author

Travis Plunk (@TravisEz13) - please re-review

@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Nov 20, 2020

Copy link
Copy Markdown
Member Author

Rob Holt (@rjmholt) This is ready for review now.

Closed
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Nov 20, 2020

Copy link
Copy Markdown
Member Author

xtqqczze - Filed issue in MarkdownRender repo to make sure the improvements mentioned above are taken there: PowerShell/MarkdownRender#11

@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Nov 24, 2020

Copy link
Copy Markdown
Member Author

Rob Holt (@rjmholt) This is ready to merge.

@ghost ghost added the Review - Needed The PR is being reviewed label Dec 2, 2020
@ghost

Deleted user (ghost) commented Dec 2, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze

xtqqczze commented Dec 2, 2020

Copy link
Copy Markdown
Contributor

Ilya (@iSazonov) We should avoid merging any more changes to Microsoft.PowerShell.MarkdownRender, like those in #14078.

@iSazonov

Ilya (iSazonov) commented Dec 2, 2020

Copy link
Copy Markdown
Collaborator

Ilya (@iSazonov) We should avoid merging any more changes to Microsoft.PowerShell.MarkdownRender, like those in #14078.

These files will simply be deleted - this does not affect anything.

@ghost ghost removed the Review - Needed The PR is being reviewed label Dec 2, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 9, 2020
@ghost

Deleted user (ghost) commented Dec 9, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@rjmholt

Rob Holt (rjmholt) commented Dec 9, 2020

Copy link
Copy Markdown
Collaborator

PoshChan-Bot (@PoshChan) please remind me in 1 hour

@ghost ghost removed the Review - Needed The PR is being reviewed label Dec 9, 2020
@rjmholt Rob Holt (rjmholt) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 9, 2020
@rjmholt
Rob Holt (rjmholt) merged commit 600b658 into PowerShell:master Dec 9, 2020
@rjmholt
Rob Holt (rjmholt) deleted the RemoveMarkRender branch December 9, 2020 20:29
@PoshChan

PoshChan-Bot (PoshChan) commented Dec 9, 2020

Copy link
Copy Markdown
Collaborator

Rob Holt (@rjmholt), this is the reminder you requested 1 hour ago

@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.2 milestone Dec 10, 2020
@rjmholt Rob Holt (rjmholt) mentioned this pull request Dec 10, 2020
Merged
8 of 14 tasks
@ghost

Deleted user (ghost) commented Dec 15, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

@xtqqczze xtqqczze mentioned this pull request Jun 29, 2021
Open
9 tasks
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan
Use Microsoft.PowerShell.MarkdownRender package from nuget.org (P…
c6642b7 
…owerShell#14090)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga

Assignees

@rjmholt Rob Holt (rjmholt)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

6 participants

@adityapatwardhan @xtqqczze @iSazonov @rjmholt @PoshChan @TravisEz13