Skip to content

Enable IDE0048: AddRequiredParentheses - #13896

Merged
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
xtqqczze:IDE0048
Oct 29, 2020
Merged

Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
xtqqczze:IDE0048

Conversation

@xtqqczze

Copy link
Copy Markdown
Contributor

@xtqqczze
xtqqczze marked this pull request as ready for review October 27, 2020 15:06
@iSazonov

Copy link
Copy Markdown
Collaborator

Default is always_for_clarity for arithmetic, relational, and other binary operators.

@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 29, 2020
@iSazonov
Ilya (iSazonov) merged commit 83a3f53 into PowerShell:master Oct 29, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Oct 29, 2020
@xtqqczze
xtqqczze deleted the IDE0048 branch October 29, 2020 14:25
@xtqqczze

Copy link
Copy Markdown
Contributor Author

This PR did not fix all IDE0048 violations, see #13936. Since the severity was set to warning, the build should not have completed!

@iSazonov

Copy link
Copy Markdown
Collaborator

Is it a bug in the Roslyn analyzer?

@xtqqczze
xtqqczze restored the IDE0048 branch October 30, 2020 14:07
@xtqqczze
xtqqczze deleted the IDE0048 branch November 2, 2020 03:51
@xtqqczze

xtqqczze commented Nov 2, 2020

Copy link
Copy Markdown
Contributor Author

Is it a bug in the Roslyn analyzer?

No EnforceCodeStyleInBuild was not enabled.

@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants