Skip to content

Fix issue #682 - [system.manage<Tab>] doesn't work - #1328

Merged
Jason Shirk (lzybkr) merged 3 commits into
masterfrom
dongbo/type-completion
Jul 8, 2016
Merged

Jason Shirk (lzybkr) merged 3 commits into
masterfrom
dongbo/type-completion

Conversation

@daxian-dbw

Copy link
Copy Markdown
Member

Resolves #682
The issue happens to CoreCLR build but not FullCLR built because the System.Management namespace exists and is available in FullCLR (WMIv1 managed APIs), but it's not in CoreCLR. The fix makes sure we can expand a namespace even if partial name of the namespace doesn't really exist as a namespace or a type name.

This PR also include the most recent changes to ALC that were checked into RS2 branch. It has been reviewed by Mike and Andy when checking in to SD.

Jason Shirk (@lzybkr) can you please review the type completion fix?
cc sergei (@vors) for the change in CommonUtilities.cs

@andyleejordan

Copy link
Copy Markdown
Member

LGTM.

1 similar comment
@lzybkr

Copy link
Copy Markdown
Contributor

LGTM.

@lzybkr
Jason Shirk (lzybkr) merged commit 5e1cbe0 into master Jul 8, 2016
@lzybkr
Jason Shirk (lzybkr) deleted the dongbo/type-completion branch July 8, 2016 23:16
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
…tion

Fix issue PowerShell#682 - [system.manage<Tab>] doesn't work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[system.manage<Tab>] doesn't work

4 participants