Skip to content

Add missing .editorconfig settings present in dotnet/runtime - #12871

Merged
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
xtqqczze:update-editorconfig
Jun 30, 2020
Merged

Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
xtqqczze:update-editorconfig

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Jun 2, 2020 •

Copy link
Copy Markdown
Contributor

PR Summary

Add settings from https://github.com/dotnet/runtime/blob/master/.editorconfig

We may want a different value for of the new settings, so please leave review comments,

PR Context

#7357

PR Checklist

@TravisEz13 Travis Plunk (TravisEz13) added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Jun 2, 2020
Comment thread .editorconfig Resolved
Comment thread .editorconfig Resolved
Comment thread .editorconfig Resolved
Comment thread .editorconfig Resolved
Comment thread .editorconfig Resolved
@xtqqczze

This comment has been minimized.

@iSazonov

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 4 pipeline(s).

@iSazonov

Copy link
Copy Markdown
Collaborator

xtqqczze Please rebase to fix CI-static.

@xtqqczze
xtqqczze force-pushed the update-editorconfig branch from 2899921 to 0086e8c Compare June 8, 2020 09:48
@TravisEz13

Copy link
Copy Markdown
Member

@ghost ghost added the Review - Needed The PR is being reviewed label Jun 22, 2020
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

@TravisEz13

Copy link
Copy Markdown
Member

@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 22, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Jun 30, 2020
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze

Copy link
Copy Markdown
Contributor Author

Dongbo Wang (@daxian-dbw) Can you please review?

@TravisEz13
Travis Plunk (TravisEz13) merged commit 940cd74 into PowerShell:master Jun 30, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 30, 2020
@xtqqczze
xtqqczze deleted the update-editorconfig branch June 30, 2020 17:45
@iSazonov Ilya (iSazonov) added this to the 7.1.0-preview.5 milestone Jun 30, 2020
@ghost

Copy link
Copy Markdown

🎉v7.1.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants