Skip to content

Add back missing files for PowerShell Core - #1285

Merged
Dongbo Wang (daxian-dbw) merged 8 commits into
masterfrom
dongbo/miss-files-ops
Jul 6, 2016
Merged

Dongbo Wang (daxian-dbw) merged 8 commits into
masterfrom
dongbo/miss-files-ops

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Jul 5, 2016 •

Copy link
Copy Markdown
Member

It resolves most of #1266. The 'Modules' item in #1266 will be analyzed and handled separately.

This PR mainly include following changes:

  1. Add back missing files
  2. Exclude certain .resx files for CoreCLR and FullCLR build
  3. Add tests for TimeZone and FileCatalog

Note that the CoreCLR version of Test-Connection doesn't work in Win10 Home Edition, but works fine in Win10 Enterprise Edition. See #1303

@daxian-dbw

Copy link
Copy Markdown
Member Author

sergei (@vors) can you please take a look?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@vors

Copy link
Copy Markdown
Collaborator

Are new test files, like Get-TimeZone.Tests.ps1 copied from source depot or they brand new? If they copied, please use PS team as an author for them.

@vors

Copy link
Copy Markdown
Collaborator

James Truher (@JamesWTruher) is working on an uber-PR to bring our existing tests. We need to give a heads-up to him, that you bring related tests in this PR

…ld VM (Windows Server 2012R2), though they always pass on Windows 10
@daxian-dbw

Copy link
Copy Markdown
Member Author

I disabled 3 FileCatalog tests because they fail on AppVeyor build VM (windows server 2012R2).
I opened #1299 to track the investigation of the failures.

@vors

Copy link
Copy Markdown
Collaborator

:shipit:

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 2f9be46 into master Jul 6, 2016
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the dongbo/miss-files-ops branch July 6, 2016 23:54
@hiteshraigandhi Hitesh Raigandhi (hiteshraigandhi) changed the title Add back missing files for OPS Add back missing files for PowerShell Core Aug 16, 2016
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants