Skip to content

"Path is not parsed correctly if '[' is present in the path" - #12170

Closed
krishnayalavarthi wants to merge 7 commits into
PowerShell:masterfrom
krishnayalavarthi:master
Closed

krishnayalavarthi wants to merge 7 commits into
PowerShell:masterfrom
krishnayalavarthi:master

Conversation

@krishnayalavarthi

@krishnayalavarthi krishnayalavarthi commented Mar 20, 2020 •

Copy link
Copy Markdown
Contributor

PR Summary

PR Context

This PR helps to fix this issue that I raised. Path is not parsed correctly if '[' is present in the path #12168

Issues fixed:
Having '[' character in directory doesn't work.

Create a directory: e:[test
Repro 1:
Test-Path 'e:[test'
Output: Error
Expected Output: True

Repro 2:
Test-Path "e:`[test"
Output: Error
Expected Output: True

PR Checklist

@SteveL-MSFT Steve Lee (SteveL-MSFT) added Breaking-Change breaking change that may affect users Review - Committee The PR/Issue needs a review from the PowerShell Committee labels Mar 21, 2020

@rjmholt Rob Holt (rjmholt) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should add tests for examples where behaviour has changed.

Also we should consider it with respect to the discussion and work done in #7399

@kwkam

kwkam commented Mar 21, 2020 •

Copy link
Copy Markdown
Contributor

This PR should add tests for examples where behaviour has changed.

Also we should consider it with respect to the discussion and work done in #7399

Actually it is #7407 which is split from #5896, 2 years ago

Edit: My bad, that is a different issue, the bracket logic is in #7399

@iSazonov

Copy link
Copy Markdown
Collaborator

Please continue discussion in #12168.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking-Change breaking change that may affect users Review - Committee The PR/Issue needs a review from the PowerShell Committee

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants