Skip to content

Update changelog generation script - #11736

Merged
6 commits merged into
PowerShell:masterfrom
xtqqczze:feature-changelog-github-compare
Feb 5, 2020
Merged

6 commits merged into
PowerShell:masterfrom
xtqqczze:feature-changelog-github-compare

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Jan 30, 2020 •

Copy link
Copy Markdown
Contributor

PR Summary

PR Context

Follow-up to #11652

PR Checklist

@xtqqczze xtqqczze mentioned this pull request Jan 30, 2020
8 of 14 tasks
@xtqqczze xtqqczze changed the title [WIP#Feature changelog GitHub compare part2 Update changelog generation script Jan 31, 2020
@xtqqczze

Copy link
Copy Markdown
Contributor Author

Travis Plunk (@TravisEz13) Since this functionality requires an additional parameter ThisReleaseTag I have avoided making changes to Get-ChangeLog. If you would like to to make changes, you could push to this branch on xtqqczze/PowerShell-PowerShell.

@iSazonov Ilya (iSazonov) added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Jan 31, 2020
@iSazonov Ilya (iSazonov) added this to the 7.1.0-preview.1 milestone Jan 31, 2020
Comment thread tools/releaseTools.psm1 Resolved
Comment thread tools/releaseTools.psm1 Resolved
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 31, 2020
@TravisEz13

Copy link
Copy Markdown
Member

Aditya Patwardhan (@adityapatwardhan) Should be port this to 7.0?

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 1, 2020
Comment thread tools/releaseTools.psm1 Resolved
@TravisEz13

Copy link
Copy Markdown
Member

PoshChan-Bot (@PoshChan) Please remind me in 4 hours

@PoshChan

Copy link
Copy Markdown
Collaborator

Travis Plunk (@TravisEz13), this is the reminder you requested 4 hours ago

Comment thread tools/releaseTools.psm1 Resolved
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 3, 2020
Address @ TravisEz13 review
@xtqqczze
xtqqczze force-pushed the feature-changelog-github-compare branch from 5278789 to dc47396 Compare February 4, 2020 23:27
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 4, 2020
@xtqqczze

xtqqczze commented Feb 4, 2020

Copy link
Copy Markdown
Contributor Author

PR is ready to merge.

@TravisEz13 Travis Plunk (TravisEz13) added the AutoMerge informs the bot to automerge the PR label Feb 4, 2020
@ghost

Copy link
Copy Markdown

Hello Travis Plunk (@TravisEz13)!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@TravisEz13 Travis Plunk (TravisEz13) added AutoMerge informs the bot to automerge the PR and removed AutoMerge informs the bot to automerge the PR labels Feb 5, 2020
@ghost
ghost merged commit e2f838e into PowerShell:master Feb 5, 2020
@xtqqczze
xtqqczze deleted the feature-changelog-github-compare branch February 6, 2020 09:17
Aditya Patwardhan (adityapatwardhan) pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Feb 18, 2020
@ghost

Copy link
Copy Markdown

🎉v7.0.0-rc.3 has been released which incorporates this pull request.:tada:

Handy links:

@xtqqczze

Copy link
Copy Markdown
Contributor Author

Travis Plunk (@TravisEz13) Any further improvements to the changelog generation script you think could be made?

@TravisEz13

Copy link
Copy Markdown
Member

Personally, I think the build and packaging section, should just list the PR numbers and not the description (perhaps thank any non-microsoft contributor).
I like this a lot more now that you have links to the full history.

@TravisEz13

Copy link
Copy Markdown
Member

Or better yet list it as details, for example

11736 Update changelog generation
<details>
<summary>11736</summary>
Update changelog generation
</details>

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
# PR Summary

* Fix regression from PowerShell#11652
* Fix [MD022](https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#md032---lists-should-be-surrounded-by-blank-lines) / [MD032](https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#md032---lists-should-be-surrounded-by-blank-lines) rule violations
* Modify `Get-ChangeLog` to generate the changelog according to the format from PowerShell#11652.

## PR Context

Follow-up to PowerShell#11652

## PR Checklist

- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
    - Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress).
    - If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)**
    - [x] None
    - **OR**
    - [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md)
        - [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
    - [x] Not Applicable
    - **OR**
    - [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
        - [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
    - [x] N/A or can only be tested interactively
    - **OR**
    - [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting)
- **Tooling**
    - [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    - **OR**
    - [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
        - Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell) for VSCode (which runs in a different PS Host).
        - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        - Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer) (which provides linting & formatting in the editor extensions).
        - Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMerge informs the bot to automerge the PR CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants