Repository navigation
Restore SetBreakpoints API - #11622
Travis Plunk (TravisEz13) merged 6 commits into
Conversation
I spoke to Dongbo Wang (@daxian-dbw) about this back when I implemented #11312 and we decided that that breakage was fine. |
Well it's not mutually exclusive -- perhaps we can have both? Also, it feels like such a decision should be documented in either the PR or the extended commit message. |
|
Yeah I thought that was captured but I guess not. I'll defer to Dongbo Wang (@daxian-dbw) for the right call here. I'm fine either way. Happy to add a comment on my old PR calling out the break. |
|
I agree to have overloads. |
ca802ba to
b06bbe4
Compare
|
Please review Paul Higinbotham (@PaulHigin) |
Travis Plunk (TravisEz13)
left a comment
There was a problem hiding this comment.
Approving as maintainer
SetBreakpoints API
* Restore SetBreakpoints API * Remove default values in API methods * Fix inheriting APIs * Correct further comments * Fix breakpoint API use issues * Fix breakpoint API tests # Conflicts: # test/powershell/SDK/Breakpoint.Tests.ps1
|
🎉 Handy links: |
* Restore SetBreakpoints API * Remove default values in API methods * Fix inheriting APIs * Correct further comments * Fix breakpoint API use issues * Fix breakpoint API tests
#11312 changed the
SetBreakpoint()API in a breaking way. This PR restores the original API while continuing to make the new one available.Tooling will be impacted by not crashing when targeting the
SetBreakpointsAPI across PowerShell versions.NOTE #11312 adds default parameters to other APIs (not broken since they were only added in the 7.0 timeframe). For compatibility it would be favourable to turn those into overloads instead.
Services #11619.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.