Skip to content

Added setting to disable implicit WinPS module loading - #11332

Merged
Aditya Patwardhan (adityapatwardhan) merged 9 commits into
PowerShell:masterfrom
anmenaga:WinCompatSetting
Jan 3, 2020
Merged

Aditya Patwardhan (adityapatwardhan) merged 9 commits into
PowerShell:masterfrom
anmenaga:WinCompatSetting

Conversation

@anmenaga

@anmenaga Andrew (anmenaga) commented Dec 12, 2019 •

Copy link
Copy Markdown

PR Summary

This adds a Boolean DisableImplicitWinCompat setting that can be set in powershell.config.json to disable implicit WinPS module loading.
Previously this code was under experimental feature check that was recently removed by Make approved features non-experimental PR.
This setting does not affect Import-Module -UseWindowsPowerShell or Import-Module -SkipEditionCheck parameter functionality.

Fix #11309

PR Context

PR Checklist

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 12, 2019
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 13, 2019
@anmenaga Andrew (anmenaga) changed the title WIP: Added setting to disable implicit WinPS module loading Added setting to disable implicit WinPS module loading Dec 13, 2019

@joeyaiello Joey Aiello (joeyaiello) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the one suggestion I added

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 20, 2019
@adityapatwardhan

Copy link
Copy Markdown
Member

Steve Lee (@SteveL-MSFT) Please update your review

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 20, 2019
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Jan 3, 2020
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit ea48e07 into PowerShell:master Jan 3, 2020
@ghost

Copy link
Copy Markdown

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add setting to powershell.config.json to disable WinPS module loading

6 participants