Skip to content

Remove the unused setting key ConsolePrompting and avoid unnecessary string creation when querying ExecutionPolicy setting - #10985

Merged
Ilya (iSazonov) merged 3 commits into
PowerShell:masterfrom
daxian-dbw:config
Nov 6, 2019
Merged

Ilya (iSazonov) merged 3 commits into
PowerShell:masterfrom
daxian-dbw:config

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Nov 4, 2019 •

Copy link
Copy Markdown
Member

PR Summary

Remove the unused setting key ConsolePrompting and avoid unnecessary string creation when querying ExecutionPolicy setting
The ConsolePrompting setting is not used anywhere because the functionality depended on it was not supporting and had been removed in #4995

The changes to GetExecutionPolicy, RemoveExecutionPolicy and SetExecutionPolicy avoid unnecessary string allocation for the default PowerShell shell Id.

PR Context

PR Checklist

@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 4, 2019
@iSazonov Ilya (iSazonov) added this to the 7.0.0-preview.6 milestone Nov 6, 2019
@iSazonov
Ilya (iSazonov) merged commit 6aa3188 into PowerShell:master Nov 6, 2019
@ghost

Copy link
Copy Markdown

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
…y string creation when querying `ExecutionPolicy` setting (PowerShell#10985)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants