Repository navigation
Remove the unused setting key ConsolePrompting and avoid unnecessary string creation when querying ExecutionPolicy setting - #10985
Merged
Conversation
Dongbo Wang (daxian-dbw)
requested a review
from Aditya Patwardhan (adityapatwardhan)
November 4, 2019 20:36
Steve Lee (SteveL-MSFT)
approved these changes
Nov 4, 2019
Dongbo Wang (daxian-dbw)
force-pushed
the
config
branch
from
November 5, 2019 18:41
39c6558 to
a0e417f
Compare
Ilya (iSazonov)
approved these changes
Nov 6, 2019
|
🎉 Handy links: |
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
…y string creation when querying `ExecutionPolicy` setting (PowerShell#10985)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Remove the unused setting key
ConsolePromptingand avoid unnecessary string creation when queryingExecutionPolicysettingThe
ConsolePromptingsetting is not used anywhere because the functionality depended on it was not supporting and had been removed in #4995The changes to
GetExecutionPolicy,RemoveExecutionPolicyandSetExecutionPolicyavoid unnecessary string allocation for the default PowerShell shell Id.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.