Skip to content

Isolate Remove-TypeData tests with runspace - #1030

Merged
Andy Jordan (andyleejordan) merged 1 commit into
masterfrom
andschwa/remote-typedata-test-fix
May 24, 2016
Merged

Andy Jordan (andyleejordan) merged 1 commit into
masterfrom
andschwa/remote-typedata-test-fix

Conversation

@andyleejordan

@andyleejordan Andy Jordan (andyleejordan) commented May 24, 2016 •

Copy link
Copy Markdown
Member

Resolves failure seen in #1028 here.


This change is Reviewable

@andyleejordan Andy Jordan (andyleejordan) added Issue-Bug Issue has been identified as a bug in the product WG-Quality-Test issues in a test or in test infrastructure labels May 24, 2016
@andyleejordan

Copy link
Copy Markdown
Member Author

s/remote/remove/g in the branch name... oh well.

@andyleejordan

Copy link
Copy Markdown
Member Author

I think this is good. Followed the same pattern as the ones we did yesterday James Truher (@JamesWTruher); merging to unblock.

@andyleejordan
Andy Jordan (andyleejordan) deleted the andschwa/remote-typedata-test-fix branch May 24, 2016 19:10
It "Remove With Pipe line Input Pass Type Shortcut String" {
$null = $ps.AddScript("Update-TypeData -MemberType NoteProperty -MemberName TestNote -Value TestNote -TypeName int").Invoke()
$ps.Commands.Clear()
$null = $ps.AddScript("(Get-TypeData System.Int32).TypeName").Invoke() | Should Be System.Int32

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

umm - this isn't right - you shouldn't have the assertion assigned to $null

@JamesWTruher

Copy link
Copy Markdown
Collaborator

just one problem
line 51 in Remove-TypeData.Tests.ps1
$null = $ps.AddScript("(Get-TypeData System.Int32).TypeName").Invoke() | Should Be System.Int32
doesn't really make sense. It should probably be:
$ps.AddScript("(Get-TypeData System.Int32).TypeName").Invoke() | Should Be System.Int32

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
…pedata-test-fix

Isolate Remove-TypeData tests with runspace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue-Bug Issue has been identified as a bug in the product WG-Quality-Test issues in a test or in test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants