Skip to content

Switch from AssemblyLoadContext.InitializeDefaultContext to AssemblyLoadContext.Resolving event - #1029

Merged
Andy Jordan (andyleejordan) merged 2 commits into
masterfrom
andschwa/initialze-default-context
May 24, 2016
Merged

Andy Jordan (andyleejordan) merged 2 commits into
masterfrom
andschwa/initialze-default-context

Conversation

@andyleejordan

@andyleejordan Andy Jordan (andyleejordan) commented May 24, 2016 •

Copy link
Copy Markdown
Member

This replaces #1019 to resolve #1016. The original PR was made from a fork, which due to authentication problems, can't pass CI (see #1028).

Thanks for your work Jan Kotas (@jkotas)!


This change is Reviewable

…oadContext.Resolving event

AssemblyLoadContext.InitializeDefaultContext was removed for .NET Core 1.0 RTM. Replaced its use
with AssemblyLoadContext.Resolving event.
PowerShellAssemblyLoadContext does not inherit from AssemblyLoadContext. Rename
it to avoid confusion.
@andyleejordan

Copy link
Copy Markdown
Member Author

Jan Kotas (@jkotas) I added you to the team with write access so next time you can push directly here and I don't have to migrate the branch. Such is life with private repos!

{
AssemblyLoadContext.InitializeDefaultContext(psAsmLoadContext);
}
catch (System.InvalidOperationException)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! This resolves #864 too.

@andyleejordan

Copy link
Copy Markdown
Member Author

This looks good to me!

@andyleejordan

Copy link
Copy Markdown
Member Author

/cc Dongbo Wang (@daxian-dbw) you'll want these changes too.

@andyleejordan
Andy Jordan (andyleejordan) deleted the andschwa/initialze-default-context branch May 24, 2016 19:18
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
…-default-context

Switch from AssemblyLoadContext.InitializeDefaultContext to AssemblyLoadContext.Resolving event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch from AssemblyLoadContext.InitializeDefaultContext to AssemblyLoadContext.Resolving event

2 participants