Repository navigation
Removal of "Encoding Byte" is a breaking change #7986
Description
The PS Core breaking change guidance is here: https://github.com/PowerShell/PowerShell/blob/master/docs/dev-process/breaking-change-contract.md
Removal of '-Encoding Byte' is a breaking change from Windows PowerShell. Although certainly a cleaner implementation, it does not meet the bar for breaking changes as identified by the guidance above.
Even if fixing this causes a breaking change for PowerShell Core, that would be far less impactful than the breaking change for users coming from Windows PowerShell.
Reacted by Michael Klement and ClauS
Activity
vexx32 commentedon Oct 10, 2018
Are you suggesting that the parameter be restored alongside the newer syntax for backwards compatibility? Just trying to clarify what your desired outcome is, really. 😄
But really, now... can't make an omelette without breaking some eggs. 😉
iSazonov commentedon Oct 11, 2018
The breaking change was approved in #5080
LeeHolmes commentedon Oct 12, 2018
New functionality is great (-AsByteStream is cool). Breaking changes that are not in line with the breaking change contract are not cool - even if previously approved.
vexx32 commentedon Oct 12, 2018
Again, what would you suggest? Restoring the
-Encodingparameter to a loosely-typed collection and addByteback in as an option? I can see why it might be nice to have for backwards-compatibility purposes on occasion, but have people actually used-Encoding Bytecommonly? I really can't say I've ever seen it (not that that means it shouldn't be restored, just trying to gauge how serious this issue could be in practice, really).LeeHolmes commentedon Oct 12, 2018
It's used 161 times in the PowerShell Corpus. (http://aka.ms/powershellcorpus)
SteveL-MSFT commentedon Nov 7, 2018
@PowerShell/powershell-committee reviewed this. This change occurred prior to the PSCore 6.0 GA where our philosophy included taking opportunity to fix issues that were known to be breaking but improving the platform. The breaking change contract was authored after 6.0 GA and we certainly have been applying it since. At this time, without additional customer feedback, it seems that the number of hits in the corpus based on the size of the corpus doesn't justify spending effort to add this back.